Re-enable DI for KeycloakService

mariovalney / laravel-keycloak-web-guard

Simple Keycloak Guard to Laravel Web Routes - https://packagist.org/packages/vizir/laravel-keycloak-web-guard

146 stars 80 forks source link

Closed agravelot closed 4 years ago

agravelot commented 4 years ago

I was using container to pass my own client implementation with custom settings.

This commit https://github.com/Vizir/laravel-keycloak-web-guard/commit/30f09ce92b1b6141a7c001b39919f8bf10915ff0 breaks because we no more use DI. The idea behind is very good, but using DI will be much cleaner. Allows passing mocked implementation for testing...

This PR re-enable dependencies injection, without breaking changes.

mariovalney commented 4 years ago

I'm sorry we broke things.

Thanks for your contribution @agravelot.