Closed indushan closed 2 years ago
mariovalney
commented
2 years ago Hi!
I'm sorry, but I'm not going to accept this changes.
The "null coalescing operator" (??) is here since 2015 and support for PHP 5 has been discontinued since 10 Jan 2019.
Said that it's a breaking change to remove a method maybe used by someone and I don't see a reason.
indushan
commented
2 years ago Hi Mario, Sorry for the late reply,The part I modified works without error in the old version (5) and version (7.4) of PHP. I checked it myself. I kindly request your attention and consider the change
On Thu, Feb 17, 2022 at 6:50 PM Mário Valney @.***> wrote:
Closed #65 https://github.com/mariovalney/laravel-keycloak-web-guard/pull/65.
— Reply to this email directly, view it on GitHub https://github.com/mariovalney/laravel-keycloak-web-guard/pull/65#event-6090255535, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEC4FARMVWYWMJLI6J6ZI33U3TY25ANCNFSM5OT66YRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: <mariovalney/laravel-keycloak-web-guard/pull/65/issue_event/6090255535@ github.com>
-- Regards, Indushan Wijekoon
Parameters changed according to the document and PHP 7 deprecation issue fixes in hasRole function