search

mariovalney / laravel-keycloak-web-guard

Simple Keycloak Guard to Laravel Web Routes - https://packagist.org/packages/vizir/laravel-keycloak-web-guard
146 stars 80 forks source link

Logout-URI Compatibility for Keycloak >= 18.0 #81

Closed serumk closed 2 years ago

MArK1done commented 2 years ago

This actually good work, had to make the changes myself in a project where I'm using keycloak 19.0. Later came here to make a pull request only to find it has been done an hour before me :).

mariovalney commented 2 years ago

Hi @serumk . Thanks for your contribution!

serumk commented 2 years ago

Hi Mario,

Am 22.09.2022 um 18:30 schrieb Mário Valney @.***>:

Hi @serumk https://github.com/serumk . Thanks for your contribution.

It's a pleasure to give something back! Would you mind to check my comments?

Sorry, which comments? Am I blind, because I can't see any comments..

best, Rudi

— Reply to this email directly, view it on GitHub https://github.com/mariovalney/laravel-keycloak-web-guard/pull/81#issuecomment-1255272659, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCXWV43SYWOGTETDNLEPZDV7SCUDANCNFSM6AAAAAAQS5WZTQ. You are receiving this because you were mentioned.

mariovalney commented 2 years ago

Sorry, which comments? Am I blind, because I can't see any comments.. best, Rudi

On commits / code review: https://docs.github.com/pt/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

serumk commented 2 years ago

Did you submit your review? I followed the instructions, but still see no comments, just my changes.