search

maritimeconnectivity / MaritimeCloud

INACTIVE: A communication framework enabling efficient, secure, reliable and seamless electronic information exchange between maritime stakeholders across available communication systems.
http://dev.maritimecloud.net
Other
13 stars 10 forks source link

Cleanup of geometry package #8

Open Boerrild opened 10 years ago

Boerrild commented 10 years ago

First of all, I believe it should be spelled "Bottom" and not "Buttom". Secondly, "buttomRightLongiture" should be "buttomRightLongitude" ("d" instead of "r"). (See mc-core/src/main/java/net/maritimecloud/util/geometry/Rectangle.java line 37)

In general I would also suggest another, less redundant naming, like for instance: NorthLatitude, SouthLatitude, EastLongitude and WestLongitude!?

kaspernielsen commented 10 years ago

) Cleanup naming ) Implement polygon properly ) Check crossings of meridians are handled properly ) Decide on static/constructor approach *) Documentation on tradeoffs with regards to a Spherical geometry implementation