maritz / nohm

node.js object relations mapper (orm) for redis
http://maritz.github.io/nohm/
MIT License
500 stars 64 forks source link

Remove void return type for propertyDiff() #189

Open rak3n opened 1 year ago

rak3n commented 1 year ago

for issue #186

rak3n commented 1 year ago

Hey @maritz, many thanks for reviewing, have added test and dropped void from return type. This will modify the way propertyDiff is used in older code to handle no differences in property for a key, so I think it will be a major bump.

maritz commented 1 year ago

This will modify the way propertyDiff is used in older code to handle no differences in property for a key, so I think it will be a major bump.

Yeah, I was thinking so as well. I'm kind of hesitant to just publish a v3 only for this rather minimal change. But on the other hand I can't really promise when other bigger changes are coming.

I guess I'll add this and some dependency updates into a v3 soon and not hold it up for other stuff.