The Mob Effect Magic Resistance protects only against indirect_magic damage sources

mariumbacchus / Soulslike-Weaponry

A minecraft mod that adds new bosses and legendary weapons

Creative Commons Zero v1.0 Universal

25 stars 11 forks source link

The Mob Effect Magic Resistance protects only against indirect_magic damage sources #109

Closed SuperHeroBaga closed 3 months ago

SuperHeroBaga commented 7 months ago

The effect Magic Resistance only protects against the damage sources of type "indirect_magic" and not "magic". I believe this is due to this line of code: "(source.isOf(DamageTypes.INDIRECT_MAGIC) || source.isOf(DamageTypes.INDIRECT_MAGIC)" One of the conditions should probably be: "source.isOf(DamageTypes.MAGIC)"

By the way I love your mod.

mariumbacchus commented 7 months ago

Yeah that is definitely a typo, thanks for pointing it out!