[BUG/CRASH] Packet overload upon boss attacks and weapon abilities [EXCEPTION_ACCESS_VIOLATION (0xc0000005)]

NoRestForWicked commented 1 month ago

Example: Minecraft: 1.20.1 Fabric: 0.15.11 Soulslike-Weaponry: 1.1.4.2

This is the crash I have been having issues with. It is the same issue the darkin scythe had before the most recent patch update (lovely patch btw). Upon the use of any attack that has particles, the client will have a packet overload and immediately crash. this happens inconstantly but many examples is The Nightfall's smash attack, the darkin blade's smash attack, comet spear calculated fall landing, Genesis fracture ability, Returning night and fallen icon smash attacks, all of the deity attacks, some night shade attacks, and I think there are more. but it regards every attack using particles and it's completely random when it happens. (By the way, you DID fix the darkin scythe's issue. So everything should be under the same list, but it seems like a lot)

No logs are generated as the game just reverts to before the crash for single player, and in multiplayer the only thing logged is the join and leaving of the player that crashed.

To reproduce, use any ability that uses a bunch of particles or fight a boss a bunch of times until the crash occurs.

Expected behavior: It shouldn't crash :) (Hey, if you're interested in joining an smp, you're more than welcome to join mine which is the main reason for me asking for the patches :D. Just thought I should mention lol)

A video of me and another member of the smp fighting a supremely config-buffed fallen icon and then crashing: https://youtu.be/c-3Qz3eLeiw

I have not tested it by itself on this version yet, but on version 1.1.3 these crashes were still prevalent while the mod was isolated.

mariumbacchus commented 1 month ago

Thanks for the video, seems like it still is an issue then. I will look into it, fixing the Umbral Trespass one did give some insight into why this happens.

And thanks for the invite! Maybe I'll join another time in the future, got a lot going on right now, but I'll let you know if the time comes.

NoRestForWicked commented 1 month ago

Yeah, it is still prevelant lol.

And of course, by all means.

By the way, I will open a new thread for this but I've completed a theme (Ima have you judge it) for the returning knight/fallen icon. I feel like fallen icon should have a 2nd phase theme and since fallen icon and returning knight are essentially the same, they get the same theme.

alltheArdy commented 2 weeks ago

Hi! Was wondering if this was fixed in a recent update? A server we host has this mod in its modpack with the version 1.1.4.2, and we have been experiencing clientside crashes on certain boss attacks

Should I get the pack devs to update the mod somehow? (the version it is on is the latest according to curseforge)

NoRestForWicked commented 2 weeks ago

It is not fixed yet, but I do believe marium is doing as best they can to resolve the issue 🔥