search

mariumbacchus / Soulslike-Weaponry

A minecraft mod that adds new bosses and legendary weapons
Creative Commons Zero v1.0 Universal
25 stars 11 forks source link

[BUG] Possible interaction issue with Bewitchment #191

Closed Pingu-Pox closed 1 month ago

Pingu-Pox commented 1 month ago

Minecraft, modloader and mod versions The platform is a Fabric server running version "0.15.11". The detected Minecraft version is "1.20.1". The process is using Java 21.0.4 (Temurin-21.0.4+7 from Eclipse Adoptium)

Soulslike-Weaponry: soulslike-weaponry-1.1.4.2-1.20.1-fabric Bewitchment: bewitchment-1.20-8

Describe the bug A above-average portion of the tick loop is taken up by Marium's Soulslike Weaponry's Forlorn mobs being affected by Bewitchment's canHaveStatusEffect() method seen here

To Reproduce Steps to reproduce the behavior:

  1. Host a server for v3.0.2 of Prominence II RPG: Hasturian Era
  2. Connect to server with appropriate version of the modpack
  3. Go to the nether
  4. Watch performance tank on a server with a few people (TPS seems fine with 4 people based on the settings in my Spark profiler, but any more than that, TPS starts to tank to 10 or below)

Expected behavior Unlike other mobs (Zombies, Skeletons, Creepers, etc.) the Forlorn seem to be affected strongly by Bewitchment's canHaveStatusEffect(). Being affected less or not at all would help with performance.

Screenshots and videos image

Other mods or relevant info Here's a Spark profile of my server being affected by the issue. I have created a matching ticket for Bewitchment.

Pingu-Pox commented 1 month ago

https://github.com/MoriyaShiine/bewitchment/issues/409

mariumbacchus commented 1 month ago

Noted, will fix that.