marius-team / marius

Large scale graph learning on a single machine.
https://marius-project.org
Apache License 2.0
160 stars 45 forks source link

[MariusGNN]Why does MariusGNN update embedding for link prediction? #140

Closed Ningsir closed 1 year ago

Ningsir commented 1 year ago

For link prediction, MariusGNN will update embedding in trainer.cpp, but the baseline(dgl and pyg) does't update embedding.Why does MariusGNN update embedding for link prediction?

JasonMoho commented 1 year ago

Our implementations of DGL and PyG link prediction do update the node embedding parameters. See below.

DGL:

PyG:

Ningsir commented 1 year ago

thanks.