search

marius-wieschollek / passwords-webextension

The official browser extension for the Passwords app for Nextcloud.
GNU General Public License v3.0
106 stars 33 forks source link

Support for keybinding to open extension popup #199

Open blacklight opened 2 years ago

blacklight commented 2 years ago

Current Status

There's no way of opening the extension's popup without grabbing the mouse and clicking on the icon.

Feature Description

Most of the browser extensions for password managers (e.g. 1Password, LastPass) have an option to open the menu upon a keybinding (e.g. Ctrl+. on 1Password). Ideally, such keybinding should be configurable, which is quite easy for Chrome/Firefox extensions through the manifest.json:

{
  "commands": {
    "open-popup": {
      "suggested_key": {
        "default": "Ctrl+."
      }
    }
  }
}
blacklight commented 2 years ago

I've just realized that this request duplicates https://github.com/marius-wieschollek/passwords-webextension/issues/130, which has been open for a while. Any plan to address this (it shouldn't be too hard to define a hook in the code and attach a command to it through the manifest) or are you open to MRs?

GrumpyMeow commented 2 years ago

"Ctrl+." does not seem to be a valid shortcut. This should be an option:

"commands": {
        "_execute_browser_action": {
            "suggested_key": {
                "default": "Alt+Shift+0"
            }
        }
    }