marius-wieschollek / passwords-webextension

The official browser extension for the Passwords app for Nextcloud.
GNU General Public License v3.0
103 stars 31 forks source link

WebExtension doesn't fill credentials (Firefox104/Edge104/Kiwi 105) #236

Closed robshnup closed 1 year ago

robshnup commented 1 year ago

Nextcloud Version: 24.04 PHP Version: 8.1 Database and Version: Mariadb 10.6. Server OS and Version: Debian 12 Passwords-version newest from NC Passwords addon-Version: 2.2.5

**Client:**

Browser and Version: FF104 /Edge 104 Client OS and Version: Win 11



### Steps to reproduce
1. The Extension ist installed and has connection to NC Server
2. Extension shows possible Credentials
3. Option "Anmeldeformulare automatisch ausfüllen" is ticked
4. Nothing is filled
5. If you click the offered website in the passwords-icon of menu-bar it is filled in most cases
6. In Kiwi-Browser you cannot do this workaround and the addon fails totally

With addon version 2.2.5 (NC 24.0.4 on Debian with PHP 8.1) fails not only with KIWI-Browser but also with Firefox 104.0 and Edge 104.0 on Windows! It has fully functioning connection to NC with all credentials but fills in nothing. You will have to copy each separately.

Addon-Debug sends this message:

    {“details”:{“data”:{“id”:“3d1576e0-56bd-47ed-ae2b-0ef39ba0ce3f”,“tab”:null,“type”:“queue.items”,“reply”:null,“silent”:false,“sender”:“background”,“channel”:“runtime”,“payload”:{“name”:“mine-process”,“items”:[{“id”:“06635462-de27-4e53-8de5-9242b0afc4ab”,“task”:{“url”:“[https://192.168.123.200/login.php",“title”:“192.168.xxx.xxx”,“password”:{“selector”:“#pass”,“value”:“xxxxxx”},“user”:{“selector”:“#user”,“value”:“xxxxx”}},“result”:{},“success”:null,“cancelled”:false}]},“receiver”:“background”},“message”:"Could](https://192.168.xxx.xxx/login.php%22,%22title%22:%22192.168.xxx.xxx %22,%22password%22:%7B%22selector%22:%22#pass%22,%22value%22:%22xxxxxx%22%7D,%22user%22:%7B%22selector%22:%22#user%22,%22value%22:%22xxxxx%22%7D%7D,%22result%22:%7B%7D,%22success%22:null,%22cancelled%22:false%7D%5D%7D,%22receiver%22:%22background%22%7D,%22message%22:%22Could) not establish connection. Receiving end does not exist.”,“file”:“moz-extension://80355f59-3e7c-474e-8c62-18f693ef49fb/js/background.js”,“line”:2,“stack”:“_sendMessage@moz-extension://80355f59-3e7c-474e-8c62-18f693ef49fb/js/background.js:2:796299\n”,“time”:1661377248505},“error”:{“name”:“Error”,“stack”:[“_sendMessage@moz-extension://80355f59-3e7c-474e-8c62-18f693ef49fb/js/background.js:2:796299”,“”],“string”:“Error: Could not establish connection. Receiving end does not exist.”,“fileName”:“moz-extension://80355f59-3e7c-474e-8c62-18f693ef49fb/js/background.js”,“lineNumber”:2,“columnNumber”:796299,“message”:“Could not establish connection. Receiving end does not exist.”}}

Hope this helps for further debugging!
marius-wieschollek commented 1 year ago

It would be great if someone with firefox could check with the development version if the issue still exists.

robshnup commented 1 year ago

With Addon-Version 2.2.6.4547 it works on many sites but just as much as not. E.g. not with Nextcloud and Github! There same behaviour in FF 104 - Doesn't fill in. Workaround with manual click works.

{"details":{"data":{"id":"8e5d6ea9-1583-45b9-889e-33d864224785","tab":null,"type":"queue.fetch","reply":null,"silent":false,"sender":"background","channel":"runtime","payload":{"name":"mine-process"},"receiver":"background"},"message":"Could not establish connection. Receiving end does not exist.","file":"moz-extension://80355f59-3e7c-474e-8c62-18f693ef49fb/js/background.js","line":2,"stack":"_sendMessage@moz-extension://80355f59-3e7c-474e-8c62-18f693ef49fb/js/background.js:2:796340\n","time":1661562817344},"error":{"name":"Error","stack":["_sendMessage@moz-extension://80355f59-3e7c-474e-8c62-18f693ef49fb/js/background.js:2:796340",""],"string":"Error: Could not establish connection. Receiving end does not exist.","fileName":"moz-extension://80355f59-3e7c-474e-8c62-18f693ef49fb/js/background.js","lineNumber":2,"columnNumber":796340,"message":"Could not establish connection. Receiving end does not exist."}}

robshnup commented 1 year ago

Now with Addon-Version 2.2.6.4549 in Firefox and 2.2.6.4547 in Chrome it works on all sites i have tested - huraah!

Only Kiwi with 2.2.6.4547 complains, that "Receiving end does not exist". Albeit it has good connection to server and finds all credentials after search. Workaround with manual click works still not. Same debug message as above.

marius-wieschollek commented 1 year ago

I haven't tested anything with Kiwi, but it seems like the communication with the content script (which fills the passwords) fails- That's what the message means. I will look into that for the next patch.