marius-wieschollek / passwords-webextension

The official browser extension for the Passwords app for Nextcloud.
GNU General Public License v3.0
103 stars 31 forks source link

[BUG]: Extension is locking my account on Active Directory #275

Open majkinetor opened 6 months ago

majkinetor commented 6 months ago

⚠️ This issue respects the following points: ⚠️

Server Information

27.1.3

Client Information

Browser and Version: Firefox 121, Chrome latest Client OS and Version: Windows 10 Extension Version: 2.5.0

Bug description

Several of my teammates were locked on Active Directory because extension keeps trying to login with invalid credentials.

Note that:

  1. NextCloud is obviously connected to AD

  2. Most of us didn't change credentials, but extension for some reason required relogin and extension showed big number of notifications about inability to login

    details There are 10s or more of these: ![image](https://github.com/marius-wieschollek/passwords-webextension/assets/85767/de87d3a2-7e2d-443c-a439-57e80944e28c)
  3. One team member actually changed the credentials on AD but didn't update it on extension, and from that moment forward extension was locking him constantly

I guess to solve this, there needs to be some form of diminishing returns to relogin, with ultimate stop of retry. This might even be configurable.

Steps to reproduce

  1. It happens on its own

Expected behavior

Extension should do its best not to spam AD server via NC or make this configurable as AD settings differ in that regard.

Extension Logs

No response