search

marius-wieschollek / passwords

A simple, yet feature rich password manager for Nextcloud
GNU Affero General Public License v3.0
215 stars 45 forks source link

"Message":"syntax error, unexpected 'SessionService' after upgrading to 21.0.3.1 #411

Closed iDontWantAUsername closed 3 years ago

iDontWantAUsername commented 3 years ago

System Information

Server:

{
    "version": {
        "server": "21.0.3.1",
        "app": "2021.7.23",
        "lsr": false,
        "php": "7.4.9"
    },
    "environment": {
        "os": "Linux",
        "architecture": "armv7l",
        "bits": 32,
        "database": "mysql",
        "cron": "cron",
        "proxy": false,
        "sslProxy": false,
        "subdirectory": false
    },
    "legacyApi": {
        "enabled": 2,
        "used": false
    },
    "services": {
        "images": "gdlib",
        "favicons": "bi",
        "previews": "default",
        "security": "hibp",
        "words": "leipzig",
        "previewApi": false,
        "faviconApi": false
    },
    "settings": {
        "channel": "stable",
        "nightlies": false,
        "handbook": false,
        "performance": 1
    },
    "encryption": {
        "sse": {
            "SSEv1r1": false,
            "SSEv1r2": true,
            "SSEv2r1": false,
            "none": true,
            "default": "none"
        },
        "cse": {
            "CSEv1r1": true,
            "none": true,
            "default": "CSEv1r1"
        }
    }
}

Client:

 Browser and Version: Chrome/91.0.4472.164
 Client OS and Version: Ubuntu 20.04.2 LTS

Steps to reproduce

  1. As admin user go to the settings page with the Passwords App enabled [index.php/settings/user] ::Internal Server Error
  2. As admin or normal user navigate to the Passwords page [index.php/apps/passwords/] ::Internal Server Error
  3. Disable App and repeat steps above ::Pages load as expected

Expected result

What should happen? Pages should load as expected

Actual result

What does happen? Internal Server Error

Nextcloud log

Nextcloud log ``` {"reqId":"US8420iouTItoiLDDjr0","level":3,"time":"2021-07-26T01:23:43+00:00","remoteAddr":"192.168.1.120","user":"admin","app":"no app in context","method":"GET","url":"/ocs/v2.php/apps/notifications/api/v2/notifications","message":{"Exception":"Exception","Message":"syntax error, unexpected 'UserSettingsService' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)","Code":0,"Trace":[{"file":"/volume1/web/NextCloud/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Notifications\\Controller\\EndpointController"},"listNotifications"]},{"file":"/volume1/web/NextCloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Notifications\\Controller\\EndpointController","listNotifications",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"apiVersion":"v2","_route":"ocs.notifications.Endpoint.listNotifications"}]},{"file":"/volume1/web/NextCloud/ocs/v1.php","line":63,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/ocsapp/apps/notifications/api/v2/notifications"]},{"file":"/volume1/web/NextCloud/ocs/v2.php","line":24,"args":["/volume1/web/NextCloud/ocs/v1.php"],"function":"require_once"}],"File":"/volume1/web/NextCloud/lib/private/AppFramework/Http/Dispatcher.php","Line":159,"Previous":{"Exception":"ParseError","Message":"syntax error, unexpected 'UserSettingsService' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)","Code":0,"Trace":[{"file":"/volume1/web/NextCloud/lib/composer/composer/ClassLoader.php","line":346,"function":"Composer\\Autoload\\includeFile","args":["/volume1/web/NextCloud/apps/passwords/lib//Services/NotificationService.php"]},{"function":"loadClass","class":"Composer\\Autoload\\ClassLoader","type":"->","args":["OCA\\Passwords\\Services\\NotificationService"]},{"function":"spl_autoload_call","args":["OCA\\Passwords\\Services\\NotificationService"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":107,"function":"__construct","class":"ReflectionClass","type":"->","args":["OCA\\Passwords\\Services\\NotificationService"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":126,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["OCA\\Passwords\\Services\\NotificationService"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":459,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["OCA\\Passwords\\Services\\NotificationService"]},{"file":"/volume1/web/NextCloud/lib/private/ServerContainer.php","line":146,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->","args":["OCA\\Passwords\\Services\\NotificationService"]},{"file":"/volume1/web/NextCloud/lib/private/Notification/Manager.php","line":150,"function":"query","class":"OC\\ServerContainer","type":"->","args":["OCA\\Passwords\\Services\\NotificationService"]},{"file":"/volume1/web/NextCloud/lib/private/Notification/Manager.php","line":295,"function":"getNotifiers","class":"OC\\Notification\\Manager","type":"->","args":[]},{"file":"/volume1/web/NextCloud/apps/notifications/lib/Controller/EndpointController.php","line":106,"function":"prepare","class":"OC\\Notification\\Manager","type":"->","args":[{"__class__":"OC\\Notification\\Notification"},"en_GB"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Http/Dispatcher.php","line":218,"function":"listNotifications","class":"OCA\\Notifications\\Controller\\EndpointController","type":"->","args":["v2"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Http/Dispatcher.php","line":127,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Notifications\\Controller\\EndpointController"},"listNotifications"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Notifications\\Controller\\EndpointController"},"listNotifications"]},{"file":"/volume1/web/NextCloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Notifications\\Controller\\EndpointController","listNotifications",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"apiVersion":"v2","_route":"ocs.notifications.Endpoint.listNotifications"}]},{"file":"/volume1/web/NextCloud/ocs/v1.php","line":63,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/ocsapp/apps/notifications/api/v2/notifications"]},{"file":"/volume1/web/NextCloud/ocs/v2.php","line":24,"args":["/volume1/web/NextCloud/ocs/v1.php"],"function":"require_once"}],"File":"/volume1/web/NextCloud/apps/passwords/lib/Services/NotificationService.php","Line":41},"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.164 Safari/537.36","version":"21.0.3.1"} {"reqId":"YJJwZyROEmrMaDNMpKe1","level":3,"time":"2021-07-26T09:42:08+00:00","remoteAddr":"192.168.1.120","user":"richard","app":"index","method":"GET","url":"/index.php/apps/passwords/api/1.0/session/keepalive","message":{"Exception":"ParseError","Message":"syntax error, unexpected 'SessionService' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)","Code":0,"Trace":[{"file":"/volume1/web/NextCloud/lib/composer/composer/ClassLoader.php","line":346,"function":"Composer\\Autoload\\includeFile","args":["/volume1/web/NextCloud/apps/passwords/lib//Controller/Api/SessionApiController.php"]},{"function":"loadClass","class":"Composer\\Autoload\\ClassLoader","type":"->","args":["OCA\\Passwords\\Controller\\Api\\SessionApiController"]},{"function":"spl_autoload_call","args":["OCA\\Passwords\\Controller\\Api\\SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":107,"function":"__construct","class":"ReflectionClass","type":"->","args":["OCA\\Passwords\\Controller\\Api\\SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":126,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["OCA\\Passwords\\Controller\\Api\\SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":459,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["OCA\\Passwords\\Controller\\Api\\SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":431,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->","args":["OCA\\Passwords\\Controller\\Api\\SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":56,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->","args":["OCA\\Passwords\\Controller\\Api\\SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":177,"function":"get","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["OCA\\Passwords\\Controller\\Api\\SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":155,"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/volume1/web/NextCloud/3rdparty/pimple/pimple/src/Pimple/Container.php","line":114,"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":122,"function":"offsetGet","class":"Pimple\\Container","type":"->","args":["SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":453,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":431,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->","args":["SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/AppFramework/App.php","line":130,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->","args":["SessionApiController"]},{"file":"/volume1/web/NextCloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["SessionApiController","keepAlive","*** sensitive parameter replaced ***",{"_route":"passwords.session_api.keep_alive"}]},{"file":"/volume1/web/NextCloud/lib/base.php","line":993,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/passwords/api/1.0/session/keepalive"]},{"file":"/volume1/web/NextCloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/volume1/web/NextCloud/apps/passwords/lib/Controller/Api/SessionApiController.php","Line":34,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.164 Safari/537.36","version":"21.0.3.1"} ```
marius-wieschollek commented 3 years ago

Looks to me like you're using PHP 7.4 on the command line but PHP 7.3 or 7.2 for you webserver. Check the PHP version reported in the system section of the admin area in NC and then either update PHP for your webserver or downgrade to Passwords 2021.7.13.

iDontWantAUsername commented 3 years ago

Thanks, i have just realised this myself, Apologies, closing