Closed rototom closed 2 years ago
marius-wieschollek
commented
3 years ago Nextcloud 23 is not yet supported and i think that might also be the cause of the issue. Try to disable nightly updates in the app settings and see if the error is resolved then.
rototom
commented
3 years ago I can't downgrade my nextcloud, can I?
marius-wieschollek
commented
3 years ago i would not recommend trying that.
rototom
commented
3 years ago So, do I have to wait for nextcloud 23 support, or can I do something?
marius-wieschollek
commented
3 years ago You can try what i suggested before: Go into the app settings for the passwords app in Nextcloud and disable the option "Shown nightly updates in appstore". That will probably fix your error. And then you can just wait for a regular update with NC 23 support which will be either 2021.12.0 or 2022.1.0
rototom
commented
3 years ago This option already is not checked.
TheColin21
commented
3 years ago After updating to Nextcloud 23 stable and enabling the (unsupported of course) passwords app, I experienced the same error. Nightly updates aren't checked here either.
marius-wieschollek
commented
3 years ago There is now a first unstable release for NC 23: https://apps.nextcloud.com/apps/passwords/releases?platform=23#23
You can install it manually.
iTimELeZz
commented
2 years ago Hey, even with nightly build, I became an internal server error when tried to access the app
marius-wieschollek
commented
2 years ago Hey, even with nightly build, I became an internal server error when tried to access the app
Do you have any error related to this in the nextcloud log?
iTimELeZz
commented
2 years ago Yes:
[passwords] Warnung: Login attempt with invalid session for user
GET /apps/passwords/ from 192.168.x.x by user at 2021-12-06T10:43:48+01:00
marius-wieschollek
commented
2 years ago That's just a warning. if there is an internal server error there should be at least an error or fatal error in the log
iTimELeZz
commented
2 years ago my bad:
Exception: Unable to verify user /var/www/nextcloud/apps/passwords/lib/Services/EnvironmentService.php - line 359:
OCA\Passwords\Services\EnvironmentService->loadUserInformation()
/var/www/nextcloud/apps/passwords/lib/Services/EnvironmentService.php - line 185:
OCA\Passwords\Services\EnvironmentService->determineAppMode()
<
marius-wieschollek
commented
2 years ago What user backend(s) are you using? SAML, LDAP etc.?
iTimELeZz
commented
2 years ago What user backend(s) are you using? SAML, LDAP etc.?
Both backends are in use, SAML and LDAP
marius-wieschollek
commented
2 years ago @iTimELeZz I tried LDAP and SAML individually, but neither causes a crash in the app. did this work with NC 22?
eglia
commented
2 years ago I'm seeing the exact same error as @iTimELeZz. I only use SAML as backend. Everything was working in NC22. Nextcloud Hub II (23.0.0) PHP 8.0.13
eglia
commented
2 years ago I did some debugging, the problem is here:
https://github.com/marius-wieschollek/passwords/blob/ac8cb5056b50be0cd2d6bca8ab0051167ee7b0e3/src/lib/Services/EnvironmentService.php#L505
for me, $loginCredentials->password is null, which is not covered by this check.
When I change the line to:
} else if(!isset($loginCredentials->password) || empty($loginCredentials->password)) {
the app now loads successfully, but I have no idea if that is a security problem or anything like that...
iTimELeZz
commented
2 years ago I did some debugging, the problem is here:
for me,
$loginCredentials->passwordis null, which is not covered by this check. When I change the line to:} else if(!isset($loginCredentials->password) || empty($loginCredentials->password)) {the app now loads successfully, but I have no idea if that is a security problem or anything like that...
tried this on my instance, and worked.. So @marius-wieschollek Would this be a fix, or is this relevant to the code, and a security issue?
marius-wieschollek
commented
2 years ago NC 23 is now supported
System Information
Server:
Client:
Steps to reproduce
Expected result
It should work
Actual result
occ is no longer usable:
In the passwords settings: PHP 7.4.21 wird ab Version 2022.1.0 nicht mehr unterstützt. Bitte sieh dir unsere Systemanforderungen an. Die letzte Hintergrundaufgabe wurde mit PHP 7.4.21 ausgeführt, der Webserver verwendet jedoch 8.0.13. Die Verwendung verschiedener Hauptversionen von PHP kann Probleme verursachen.
I updated php from 7.4 to 8.0. php7.4 is completely uninstalled, php -v at the terminal says "PHP 8.0.13 (cli) ", fpm and apache run with 8.0, too.
Nextcloud log
Nextcloud log
``` {"reqId":"sQob7MZyO79iRmZExGYD","level":3,"time":"2021-11-26T01:20:02+00:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"Error while running background job (class: OC\\Migration\\BackgroundRepair, arguments: Array\n(\n [app] => passwords\n [step] => OCA\\Passwords\\Migration\\AutoBackupRestore\n)\n)","userAgent":"--","version":"23.0.0.9","exception":{"Exception":"ArgumentCountError","Message":"Too few arguments to function OC\\App\\AppStore\\Fetcher\\Fetcher::__construct(), 5 passed in /var/www/nextcloud/apps/passwords/lib/Fetcher/NightlyAppFetcher.php on line 92 and exactly 6 expected","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/passwords/lib/Fetcher/NightlyAppFetcher.php","line":92,"function":"__construct","class":"OC\\App\\AppStore\\Fetcher\\Fetcher","type":"->"},{"function":"__construct","class":"OCA\\Passwords\\Fetcher\\NightlyAppFetcher","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"newInstanceArgs","class":"ReflectionClass","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/ServerContainer.php","line":145,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/Repair.php","line":140,"function":"query","class":"OC\\ServerContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/Migration/BackgroundRepair.php","line":98,"function":"addStep","class":"OC\\Repair","type":"->"},{"file":"/var/www/nextcloud/lib/private/BackgroundJob/Job.php","line":51,"function":"run","class":"OC\\Migration\\BackgroundRepair","type":"->"},{"file":"/var/www/nextcloud/lib/private/BackgroundJob/TimedJob.php","line":58,"function":"execute","class":"OC\\BackgroundJob\\Job","type":"->"},{"file":"/var/www/nextcloud/lib/private/Migration/BackgroundRepair.php","line":71,"function":"execute","class":"OC\\BackgroundJob\\TimedJob","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":128,"function":"execute","class":"OC\\Migration\\BackgroundRepair","type":"->"}],"File":"/var/www/nextcloud/lib/private/App/AppStore/Fetcher/Fetcher.php","Line":70,"CustomMessage":"Error while running background job (class: OC\\Migration\\BackgroundRepair, arguments: Array\n(\n [app] => passwords\n [step] => OCA\\Passwords\\Migration\\AutoBackupRestore\n)\n)"},"id":"61a0393b60ac7"} ```