Setting favicon server causes an error when trying to open user settings

shermzm commented 2 years ago

System Information

Server:

{
    "version": {
        "server": "23.0.0.10",
        "app": "2022.1.20",
        "lsr": false,
        "php": "8.0.14"
    },
    "environment": {
        "os": "Linux",
        "architecture": "x86_64",
        "bits": 64,
        "database": "mysql",
        "cron": "cron",
        "proxy": false,
        "sslProxy": false,
        "subdirectory": false
    },
    "services": {
        "images": "gdlib",
        "favicons": "bi",
        "previews": "pageres",
        "security": "hibp",
        "words": "leipzig",
        "previewApi": false,
        "faviconApi": true
    },
    "settings": {
        "channel": "stable",
        "nightlies": false,
        "handbook": false,
        "performance": 5
    },
    "encryption": {
        "sse": {
            "SSEv1r1": false,
            "SSEv1r2": true,
            "SSEv2r1": false,
            "none": false,
            "default": "SSEv1r2"
        },
        "cse": {
            "CSEv1r1": false,
            "none": true,
            "default": "none"
        }
    }
}

Passwords:

        "passwords": {
            "SSEv1ServerKey": "AReallyLongString",
            "backup\/update\/restored": "0",
            "cron\/php\/version\/id": "80014",
            "cron\/php\/version\/string": "8.0.14",
            "enabled": "yes",
            "installed_version": "2022.1.20",
            "legacy_last_used": "1609527110",
            "migration\/customFields": "2020.12.2",
            "passwords\/localdb\/type": "hibp",
            "service\/favicon": "bi",
            "service\/favicon\/bi\/counter": "52:249:0",
            "service\/favicon\/bi\/url": "http:\/\/192.168.1.10:8192",
            "service\/preview": "pageres",
            "service\/words": "leipzig",
            "survey\/server\/mode": "0",
            "survey\/server\/notification": "1625180009",
            "types": ""
        }

Client:

 Browser and Version: Firefox 95.0.2
 Client OS and Version: Arch

Steps to reproduce

Enable the passwords app
(possible) Set an favicon server in the system settings
Attempting to access the user settings causes an Internal Server Error

Expected result

You can view user settings

Actual result

Internal Server Error

Nextcloud log

Browser log

Uncaught TypeError: r is undefined r index.js:178 main.js:25 main.js:196 main.js:196

marius-wieschollek commented 2 years ago

This error seems a bit strange to me. The url in the error from the Nextcloud log is /index.php/apps/passwords/api/1.0/service/favicon/default/96, so it occurred when a favicon was requested. It occurred in the ClassLoader with the message "syntax error, unexpected '=>' (T_DOUBLE_ARROW)". So the error happened before the passwords app itself did anything. My first assumption would be that the error is not related to the setting and instead happens whenever the server attempts to load the HelperService. The service includes some code with a double arrow which only works in PHP 8.

The PHP version on the command line and the PHP version used by the webserver can be different. Can you check which PHP version is reported in the system section of the Nextcloud admin settings?

shermzm commented 2 years ago

Welp, that might have done it. I upgraded everything to PHP8, but left PHP7 installed. After rebooting the server for the first time in a few months, it looks like something reverted back to PHP7. I must have missed updating systemd or something. I'll check tonight to see if that resolves everything or not.

Thanks for your help in pointing me in the right direction!

shermzm commented 2 years ago

Sure enough, php-fpm7 was running instead of php-fpm (8). Loaded the correct one and everything is working fine. Updated systemd to start the correct one moving forward.

Thanks again Marius!

marius-wieschollek / passwords