search

marius-wieschollek / passwords

A simple, yet feature rich password manager for Nextcloud
GNU Affero General Public License v3.0
215 stars 45 forks source link

Three types of ParseError are generated #497

Closed Bables55 closed 2 years ago

Bables55 commented 2 years ago

System Information

Server:

{
    "version": {
        "server": "23.0.3.2",
        "app": "2022.3.20",
        "lsr": false,
        "php": "8.0.16",
        "cronPhp": "7.4.28"
    },
    "environment": {
        "os": "Linux",
        "architecture": "x86_64",
        "bits": 64,
        "database": "mysql",
        "cron": "cron",
        "proxy": false,
        "sslProxy": false,
        "subdirectory": false
    },
    "services": {
        "images": "imagick",
        "favicons": "ddg",
        "previews": "default",
        "security": "hibp",
        "words": "leipzig",
        "previewApi": false,
        "faviconApi": false
    },
    "status": {
        "autoBackupRestored": false
    },
    "settings": {
        "channel": "stable",
        "nightlies": false,
        "handbook": false,
        "performance": 5
    },
    "encryption": {
        "sse": {
            "SSEv1r1": false,
            "SSEv1r2": true,
            "SSEv2r1": false,
            "none": false,
            "default": "SSEv1r2"
        },
        "cse": {
            "CSEv1r1": false,
            "none": true,
            "default": "none"
        }
    }
}

Steps to reproduce

  1. View Log

    Expected result

    No errors

Actual result

No real harm experienced by the user. I have experienced this several times. Versions have been released repeatedly where this problem does not occur, and versions where it does occur.

Nextcloud log

Nextcloud log ``` {"reqId":"dv27qukPOnuXnBHGQuI4","level":3,"time":"2022-04-01T19:17:52+09:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"Error while running background job (class: OC\\Migration\\BackgroundRepair, arguments: Array\n(\n [app] => passwords\n [step] => OCA\\Passwords\\Migration\\DatabaseObjectRepair\n)\n)","userAgent":"--","version":"23.0.3.2","exception":{"Exception":"ParseError","Message":"syntax error, unexpected '$this' (T_VARIABLE), expecting function (T_FUNCTION) or const (T_CONST)","Code":0,"Trace":[{"file":"/var/www/NEXTCLOUD/lib/composer/composer/ClassLoader.php","line":428,"function":"Composer\\Autoload\\includeFile"},{"function":"loadClass","class":"Composer\\Autoload\\ClassLoader","type":"->"},{"file":"/var/www/NEXTCLOUD/apps/passwords/lib/Migration/DatabaseRepair/TagRevisionRepair.php","line":24,"function":"spl_autoload_call"},{"file":"/var/www/NEXTCLOUD/lib/composer/composer/ClassLoader.php","line":571,"args":["/var/www/NEXTCLOUD/apps/passwords/lib/Migration/DatabaseRepair/TagRevisionRepair.php"],"function":"include"},{"file":"/var/www/NEXTCLOUD/lib/composer/composer/ClassLoader.php","line":428,"function":"Composer\\Autoload\\includeFile"},{"function":"loadClass","class":"Composer\\Autoload\\ClassLoader","type":"->"},{"function":"spl_autoload_call"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":112,"function":"__construct","class":"ReflectionClass","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/ServerContainer.php","line":145,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Repair.php","line":141,"function":"query","class":"OC\\ServerContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Migration/BackgroundRepair.php","line":98,"function":"addStep","class":"OC\\Repair","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/BackgroundJob/Job.php","line":51,"function":"run","class":"OC\\Migration\\BackgroundRepair","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/BackgroundJob/TimedJob.php","line":58,"function":"execute","class":"OC\\BackgroundJob\\Job","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Migration/BackgroundRepair.php","line":71,"function":"execute","class":"OC\\BackgroundJob\\TimedJob","type":"->"},{"file":"/var/www/NEXTCLOUD/cron.php","line":150,"function":"execute","class":"OC\\Migration\\BackgroundRepair","type":"->"}],"File":"/var/www/NEXTCLOUD/apps/passwords/lib/Migration/DatabaseRepair/AbstractRevisionRepair.php","Line":69,"CustomMessage":"Error while running background job (class: OC\\Migration\\BackgroundRepair, arguments: Array\n(\n [app] => passwords\n [step] => OCA\\Passwords\\Migration\\DatabaseObjectRepair\n)\n)"},"id":"6246d2d806194"} {"reqId":"dv27qukPOnuXnBHGQuI4","level":3,"time":"2022-04-01T19:17:52+09:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"Error while running background job (class: OC\\Migration\\BackgroundRepair, arguments: Array\n(\n [app] => passwords\n [step] => OCA\\Passwords\\Migration\\CheckAppSettings\n)\n)","userAgent":"--","version":"23.0.3.2","exception":{"Exception":"ParseError","Message":"syntax error, unexpected '=>' (T_DOUBLE_ARROW)","Code":0,"Trace":[{"file":"/var/www/NEXTCLOUD/lib/composer/composer/ClassLoader.php","line":428,"function":"Composer\\Autoload\\includeFile"},{"function":"loadClass","class":"Composer\\Autoload\\ClassLoader","type":"->"},{"function":"spl_autoload_call"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":112,"function":"__construct","class":"ReflectionClass","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/ServerContainer.php","line":145,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Repair.php","line":141,"function":"query","class":"OC\\ServerContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Migration/BackgroundRepair.php","line":98,"function":"addStep","class":"OC\\Repair","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/BackgroundJob/Job.php","line":51,"function":"run","class":"OC\\Migration\\BackgroundRepair","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/BackgroundJob/TimedJob.php","line":58,"function":"execute","class":"OC\\BackgroundJob\\Job","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Migration/BackgroundRepair.php","line":71,"function":"execute","class":"OC\\BackgroundJob\\TimedJob","type":"->"},{"file":"/var/www/NEXTCLOUD/cron.php","line":150,"function":"execute","class":"OC\\Migration\\BackgroundRepair","type":"->"}],"File":"/var/www/NEXTCLOUD/apps/passwords/lib/Services/HelperService.php","Line":117,"CustomMessage":"Error while running background job (class: OC\\Migration\\BackgroundRepair, arguments: Array\n(\n [app] => passwords\n [step] => OCA\\Passwords\\Migration\\CheckAppSettings\n)\n)"},"id":"6246d2d806228"} {"reqId":"dv27qukPOnuXnBHGQuI4","level":3,"time":"2022-04-01T19:17:52+09:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"Error while running background job (class: OC\\Migration\\BackgroundRepair, arguments: Array\n(\n [app] => passwords\n [step] => OCA\\Passwords\\Migration\\AutoBackupRestore\n)\n)","userAgent":"--","version":"23.0.3.2","exception":{"Exception":"ParseError","Message":"syntax error, unexpected '=>' (T_DOUBLE_ARROW)","Code":0,"Trace":[{"file":"/var/www/NEXTCLOUD/lib/composer/composer/ClassLoader.php","line":428,"function":"Composer\\Autoload\\includeFile"},{"function":"loadClass","class":"Composer\\Autoload\\ClassLoader","type":"->"},{"function":"spl_autoload_call"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":112,"function":"__construct","class":"ReflectionClass","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":435,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":87,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":106,"function":"array_map"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":114,"function":"buildClass","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/Utility/SimpleContainer.php","line":131,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":463,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/ServerContainer.php","line":145,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Repair.php","line":141,"function":"query","class":"OC\\ServerContainer","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Migration/BackgroundRepair.php","line":98,"function":"addStep","class":"OC\\Repair","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/BackgroundJob/Job.php","line":51,"function":"run","class":"OC\\Migration\\BackgroundRepair","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/BackgroundJob/TimedJob.php","line":58,"function":"execute","class":"OC\\BackgroundJob\\Job","type":"->"},{"file":"/var/www/NEXTCLOUD/lib/private/Migration/BackgroundRepair.php","line":71,"function":"execute","class":"OC\\BackgroundJob\\TimedJob","type":"->"},{"file":"/var/www/NEXTCLOUD/cron.php","line":150,"function":"execute","class":"OC\\Migration\\BackgroundRepair","type":"->"}],"File":"/var/www/NEXTCLOUD/apps/passwords/lib/Services/HelperService.php","Line":117,"CustomMessage":"Error while running background job (class: OC\\Migration\\BackgroundRepair, arguments: Array\n(\n [app] => passwords\n [step] => OCA\\Passwords\\Migration\\AutoBackupRestore\n)\n)"},"id":"6246d2d8063a2"} ```
marius-wieschollek commented 2 years ago 
        "php": "8.0.16",
        "cronPhp": "7.4.28"

This seems to be the issue. Your cronjobs / CLI commands are executed with PHP 7.4, but you're using the version of Passwords for PHP 8/8.1. Use the LSR version or switch the CLI version of PHP to 8.x

Bables55 commented 2 years ago

Your cronjobs / CLI commands are executed with PHP 7.4

Thanks for pointing that out. I was running cron on PHP 7.4. I modified to PHP 8.0 and the error is gone.