marius-wieschollek / passwords

A simple, yet feature rich password manager for Nextcloud
GNU Affero General Public License v3.0
215 stars 45 forks source link

Incompatible declaration of Entity::setter($name, $args) #573

Closed blizzz closed 1 year ago

blizzz commented 1 year ago

System Information

Server:

 Nextcloud Version: 25.0.4RC1
 PHP Version: 8.1
 Passwords Version: 2023.2.20-build4829

Steps to reproduce

  1. Have Passwords enabled
  2. Upgrade to 25.0.4RC1 via web interface

Expected result

Upgrade goes smoothly

Actual result

Upgrade procedure fails with: Declaration of OCA\Passwords\Db\Traits\GetterSetterTrait::setter(string $name, array $args): void must be compatible with OCP\AppFramework\Db\Entity::setter($name, $args) (only visible in logs)

Takes a manual occ upgrade and off maintenance:mode --off to complete the update.

Nextcloud log

{
  "reqId": "cBSd1P45mMlu2qiQiGl2",
  "level": 3,
  "time": "2023-02-09T17:53:00+00:00",
  "remoteAddr": "2001:4091:a246:80f3:4231:5227:28de:d63b",
  "user": "--",
  "app": "PHP",
  "method": "GET",
  "url": "/core/ajax/update.php?requesttoken=7gptxCh0fbAskqcvx0vTHo%2B2F%2FakacyD4bvvnzQUjqY%3D%3AvG5Go3FCCoMb%2FPJ6r3yKesGAbsGdGpvKlNnW%2FF58xf4%3D",
  "message": "Declaration of OCA\\Passwords\\Db\\Traits\\GetterSetterTrait::setter(string $name, array $args): void must be compatible with OCP\\AppFramework\\Db\\Entity::setter($name, $args) at /path/to/nextcloud/apps/passwords/lib/Db/Traits/GetterSetterTrait.php#22",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "25.0.3.2",
  "data": {
    "app": "PHP"
  }
}