marius-wieschollek / passwords

A simple, yet feature rich password manager for Nextcloud
GNU Affero General Public License v3.0
202 stars 40 forks source link

[BUG]: PHP Fatal Error after upgrade #585

Closed Aonodensetsu closed 1 year ago

Aonodensetsu commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Server Information

Bug started upon upgrade to Nextcloud 26, MariaDB, Debian, */5 * * * * php -f /var/www/nextcloud/cron.php, PHP 8.0.28 (cli)

Client Information

Browser and Version: Firefox latest / Chrome latest Client OS and Version: Windows 11 latest

Bug description

https://github.com/nextcloud/server/issues/37376 PHP Fatal error: Declaration of OCA\Passwords\Db\Traits\GetterSetterTrait::getter(string $name) must be compatible with OCP\AppFramework\Db\Entity::getter(string $name): mixed in /var/www/nextcloud/apps/passwords/lib/Db/AbstractEntity.php on line 66 when running occ and in logs

Steps to reproduce

  1. use any occ command

Expected behavior

occ command runs successfully

Nextcloud Logs

no relevant errors except `{"reqId":"12EVFzAuwFmri8wAZi3z","level":3,"time":"2023-03-23T18:40:00+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Declaration of OCA\\Passwords\\Db\\Traits\\GetterSetterTrait::getter(string $name) must be compatible with OCP\\AppFramework\\Db\\Entity::getter(string $name): mixed at /var/www/nextcloud/apps/passwords/lib/Db/AbstractEntity.php#66","userAgent":"--","version":"26.0.0.11","data":{"app":"PHP"},"id":"641c9d4fb161f"}` which mirrors the CLI error

Browser Logs

as above
marius-wieschollek commented 1 year ago

What version of the app do you use?

Aonodensetsu commented 1 year ago

2023.3.11, which was installed by the nextcloud updater

FlimFlam commented 1 year ago

Same problem here. Version 2023.3.11. Error occurred after updating to Nextcloud 26. PHP 8.0.28 My password app says "version for obsolete systems". Bildschirmfoto vom 2023-03-25 15-56-16

dontinelli commented 1 year ago

Have the same problem as well. I saw that in the GitLab repository commits to resolve this bug have been made (https://git.mdns.eu/nextcloud/passwords/-/commit/82664483bb5e5b298e8892906cb0f62fc11d72f7). @marius-wieschollek: Is there a timeline when those will be available in NC?

FlimFlam commented 1 year ago

With version 2023.4.0 the bug is gone for me.

dontinelli commented 1 year ago

With version 2023.4.0 the bug is gone for me.

I just saw the update in NC and can confirm that the bug has been resolved for me as well.