marius-wieschollek / passwords

A simple, yet feature rich password manager for Nextcloud
GNU Affero General Public License v3.0
202 stars 40 forks source link

[BUG]: Wrong link to breached passwords in navigation #590

Closed fdiwald closed 1 year ago

fdiwald commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Server Information

{
    "version": {
        "server": "25.0.6.1",
        "app": "2023.4.30",
        "lsr": false,
        "php": "8.1.12",
        "cronPhp": "8.1.12"
    },
    "environment": {
        "os": "Linux",
        "architecture": "x86_64",
        "bits": 64,
        "database": "mysql",
        "cron": "cron",
        "proxy": false,
        "sslProxy": false,
        "subdirectory": true
    },
    "services": {
        "images": "imagick",
        "favicons": "bi",
        "previews": "default",
        "security": "hibp",
        "words": "auto",
        "previewApi": false,
        "faviconApi": false
    },
    "status": {
        "autoBackupRestored": false
    },
    "settings": {
        "channel": "stable",
        "nightlies": false,
        "handbook": false,
        "performance": 5
    },
    "encryption": {
        "sse": {
            "SSEv1r1": false,
            "SSEv1r2": true,
            "SSEv2r1": false,
            "SSEv3r1": false,
            "none": false,
            "default": "SSEv1r2"
        },
        "cse": {
            "CSEv1r1": false,
            "none": true,
            "default": "none"
        }
    }
}

Client Information

Browser and Version: Firefox 112.0.2 Client OS and Version: Windows 10.0.19045

Bug description

In the navigation bar on the left under "Security" I have the options "Secure", "Weak" and "Breached" The link behind the "Breached" navigation item points to the wrong location /nextcloud/apps/passwords/#/security/3. A "2" at the end would be correct.

Note: When I select the "Security" navigation item, the three subcategories are listed in the main area to the right. The link of the "Breached" item in this list correctly points to /nextcloud/apps/passwords/#/security/2. So the error only affects the navigation items in the navigation bar on the left.

The error left me a bit confused as I got a notification, that some of my passwords were breached. When I wanted to check the list later that day, I got the "There is nothing here; That's probably a good sign" message.

This should be an easy fix in https://github.com/marius-wieschollek/passwords/blob/master/src/vue/Components/Navigation/AppNavigationItemSecurity.vue As soon as I have time, I will create a PullRequest.

Steps to reproduce

Create a password entry with a breached password like password. Navigate to "Security" in the navigation bar and select the "Breached" item in the list in the main area on the right. See the breached password in the list. Click the "Breached" navigation item in the navigation pane. See the placeholder message for the empty list.

Expected behavior

The "Breached" navigation item in the navigation bar should point to /nextcloud/apps/passwords/#/security/2 instead of /nextcloud/apps/passwords/#/security/3.

Nextcloud Logs

No response

Browser Logs

No response

fdiwald commented 1 year ago

This has been fixed (quite fast) with Version 2023.5.30. Thanks @marius-wieschollek