marius-wieschollek / passwords

A simple, yet feature rich password manager for Nextcloud
GNU Affero General Public License v3.0
208 stars 42 forks source link

[FEATURE]: Allow other protocols than http:// in URL field #605

Closed godfuture closed 10 months ago

godfuture commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Current Status

Currently http:// is enforced when entering an URL. This means that e.g. a network ressource in Windows like "\myhost\myshare" is never valid for entry. This is kind of odd, because I would like to store also this password in Password app.

Feature Description

The URL field should be able to hold many different types of URI. Like the smb:// or Windows shares that start with \host\share or ftp:// and so on.

  1. Open Nextcloud password website
  2. Add a new password
  3. Enter User, password and URL field
  4. The URL field does not enforce the http protocol

Additional Context

I understand this behavior is because the URL field was meant for websites. Generally, the Password app could be a perfect password safe (which I try to use it for), but this feature is missing to make it a full replacement for other services.

marius-wieschollek commented 1 year ago

The "Website" field allows any valid URI, regardless of protocol, but will prefix the https:// protocol if none is given.

Windows network names aren't valid URIs and can't be used as such.

The use of the website field is to create a link that the user can click to get to the page. What browsers do with a windows share is unpredictable and therefore a potential security risk.

I recommend to create a custom text field to store windows share addresses.