[BUG]: Using where() on non-empty WHERE part in lib/Db/SessionMapper.php

[come-nc]

⚠️ This issue respects the following points: ⚠️

• [X] This is a single bug, not a question or a configuration/webserver/proxy issue.
• [X] This is not a bug in the browser extension or another client.
• [X] This issue is not already reported on Github (I've searched it).
• [X] Nextcloud Server and the Passwords App is up to date. See Nextcloud Apps.
• [X] There are no warnings and errors reported in the Passwords App settings in the admin area
• [X] The following apps are not installed: Rainloop

Server Information

Unknown

Client Information

Browser and Version: Client OS and Version:

Bug description

I stumbled on this issue in logs, and it seems to still be present in master, since https://git.mdns.eu/nextcloud/passwords/-/blob/master/src/lib/Db/SessionMapper.php?ref_type=heads#L29 overrides what’s in https://git.mdns.eu/nextcloud/passwords/-/blob/master/src/lib/Db/AbstractMapper.php?ref_type=heads#L248

Not sure if this leads to a problematic behavior.

Steps to reproduce

-

Expected behavior

-

Nextcloud Logs

{
  "reqId": "***",
  "level": 2,
  "time": "***",
  "remoteAddr": "",
  "user": "--",
  "app": "no app in context",
  "method": "",
  "url": "--",
  "message": "Using where() on non-empty WHERE part, please verify it is intentional to not call whereAnd() or whereOr() instead. Otherwise consider creating a new query builder object or call resetQueryPart('where') first.",
  "userAgent": "--",
  "version": "27.0.2.2",
  "exception": {
    "Exception": "Doctrine\\DBAL\\Query\\QueryException",
    "Message": "Using where() on non-empty WHERE part, please verify it is intentional to not call whereAnd() or whereOr() instead. Otherwise consider creating a new query builder object or call resetQueryPart('where') first.",
    "Code": 0,
    "Trace": [
      {
        "file": "***/nextcloud/apps/passwords/lib/Db/SessionMapper.php",
        "line": 29,
        "function": "where",
        "class": "OC\\DB\\QueryBuilder\\QueryBuilder",
        "type": "->"
      },
      {
        "file": "***/nextcloud/apps/passwords/lib/Helper/CleanUp/CleanSessionsHelper.php",
        "line": 45,
        "function": "findAllOlderThan",
        "class": "OCA\\Passwords\\Db\\SessionMapper",
        "type": "->"
      },
      {
        "file": "***/nextcloud/apps/passwords/lib/Cron/CleanUpEntities.php",
        "line": 59,
        "function": "run",
        "class": "OCA\\Passwords\\Helper\\CleanUp\\CleanSessionsHelper",
        "type": "->"
      },
      {
        "file": "***/nextcloud/apps/passwords/lib/Cron/AbstractTimedJob.php",
        "line": 59,
        "function": "runJob",
        "class": "OCA\\Passwords\\Cron\\CleanUpEntities",
        "type": "->"
      },
      {
        "file": "***/nextcloud/lib/public/BackgroundJob/Job.php",
        "line": 81,
        "function": "run",
        "class": "OCA\\Passwords\\Cron\\AbstractTimedJob",
        "type": "->"
      },
      {
        "file": "***/nextcloud/lib/public/BackgroundJob/TimedJob.php",
        "line": 103,
        "function": "start",
        "class": "OCP\\BackgroundJob\\Job",
        "type": "->"
      },
      {
        "file": "***/nextcloud/lib/public/BackgroundJob/TimedJob.php",
        "line": 93,
        "function": "start",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->"
      },
      {
        "file": "***/nextcloud/cron.php",
        "line": 152,
        "function": "execute",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->"
      }
    ],
    "File": "***/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php",
    "Line": 869,
    "message": "Using where() on non-empty WHERE part, please verify it is intentional to not call whereAnd() or whereOr() instead. Otherwise consider creating a new query builder object or call resetQueryPart('where') first.",
    "exception": {},
    "CustomMessage": "Using where() on non-empty WHERE part, please verify it is intentional to not call whereAnd() or whereOr() instead. Otherwise consider creating a new query builder object or call resetQueryPart('where') first."
  }
}

Browser Logs

No response

[marius-wieschollek]

This should be fixed with 2023.10.0