[BUG]: Exception: OCA\Passwords\Notification\UpgradeRequiredNotification::getMessage(): Argument #4 ($appVersion) must be of type string, null given

roru69 commented 5 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a single bug, not a question or a configuration/webserver/proxy issue.
[X] This is not a bug in the browser extension or another client.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server and the Passwords App is up to date. See Nextcloud Apps.
[X] There are no warnings and errors reported in the Passwords App settings in the admin area
[X] The following apps are not installed: Rainloop

Server Information

{
    "version": {
        "server": "27.1.5.1",
        "app": "2023.12.32",
        "lsr": false,
        "php": "8.2.14",
        "cronPhp": "8.2.14"
    },
    "environment": {
        "os": "Linux",
        "architecture": "x86_64",
        "bits": 64,
        "database": "mysql",
        "cron": "cron",
        "proxy": false,
        "sslProxy": true,
        "subdirectory": false
    },
    "services": {
        "images": "imagick",
        "favicons": "bi",
        "previews": "pageres",
        "security": "hibp",
        "words": "auto",
        "previewApi": false,
        "faviconApi": false
    },
    "status": {
        "autoBackupRestored": false
    },
    "settings": {
        "channel": "beta",
        "nightlies": false,
        "handbook": false,
        "performance": 5
    },
    "encryption": {
        "sse": {
            "SSEv1r1": false,
            "SSEv1r2": true,
            "SSEv2r1": false,
            "SSEv3r1": false,
            "none": false,
            "default": "SSEv1r2"
        },
        "cse": {
            "CSEv1r1": false,
            "none": true,
            "default": "none"
        }
    }
}

Client Information

Browser and Version: Edge - Version 120.0.2210.121 (Official build) (64-bits) Client OS and Version: Windows Server 2019

Nextcloud is running behind a IIS reverse proxy.

Bug description

Every 5 seconds the following exception is thrown in the nextcloud log:

Exception: OCA\Passwords\Notification\UpgradeRequiredNotification::getMessage(): Argument #4 ($appVersion) must be of type string, null given, called in /var/www/nextcloud/apps/passwords/lib/Notification/UpgradeRequiredNotification.php on line 89 in file '/var/www/nextcloud/apps/passwords/lib/Notification/UpgradeRequiredNotification.php' line 128

Undefined array key "appVersion" at /var/www/nextcloud/apps/passwords/lib/Notification/UpgradeRequiredNotification.php#89

Steps to reproduce

Everything seems to work fine, only my log is getting hammered by this exeption

Expected behavior

No exceptions in the Nextcloud log

Nextcloud Logs

Exception: OCA\Passwords\Notification\UpgradeRequiredNotification::getMessage(): Argument #4 ($appVersion) must be of type string, null given, called in /var/www/nextcloud/apps/passwords/lib/Notification/UpgradeRequiredNotification.php on line 89 in file '/var/www/nextcloud/apps/passwords/lib/Notification/UpgradeRequiredNotification.php' line 128

Undefined array key "appVersion" at /var/www/nextcloud/apps/passwords/lib/Notification/UpgradeRequiredNotification.php#89

Browser Logs

No response

nikhub commented 5 months ago

I can confirm the exact same issue. The error message appears at least every minute in my Nextcloud Servers log file. Nextcloud Server version: 27.1.5.1 Passwords App version: 2023.12.32

Exception: OCA\Passwords\Notification\UpgradeRequiredNotification::getMessage(): Argument #4 ($appVersion) must be of type string, null given, called in /var/www/html/nextcloud/apps/passwords/lib/Notification/UpgradeRequiredNotification.php on line 89 in file '/var/www/html/nextcloud/apps/passwords/lib/Notification/UpgradeRequiredNotification.php' line 128

marius-wieschollek commented 3 months ago

Is this issue still present with the current version of the app?

nikhub commented 3 months ago

I recently updated to Nextcloud 28.0.3 and PHP8.3. Nextcloud Passwords App version currently is 2024.3.20. I checked my log for the error message, but could not find it. Looks like it is fixed in my case. Thank you very much!

roru69 commented 3 months ago

Same here. No more entries in my log concerning this error. Now on Nextcloud 2.8.0.3 - Latest build Passwords. So it looks fixed in my case also! Thanks!!

marius-wieschollek / passwords