BUG]: Accessibility issue – In Password app hidden button after the password record.

citygabor commented 5 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a single bug, not a question or a configuration/webserver/proxy issue.
[X] This is not a bug in the browser extension or another client.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server and the Passwords App is up to date. See Nextcloud Apps.
[X] There are no warnings and errors reported in the Passwords App settings in the admin area
[X] The following apps are not installed: Rainloop

Server Information

TrueNAS - Scale
Kobia 2023.10.01

Client Information

Client: MS Edge version: 121.0.2277.83 OS: Windows 11 Professional verzió 23H2 (OS Build 22631.3007)

Bug description

Hello Marius David Wieschollek ,

Server: OS: Truenas 2023.10.01 Password version: 2024.1.21 NextCloud version: 28.0.1

Client: MS Edge version: 121.0.2277.83 OS: Windows 11 Professional verzió 23H2 (OS Build 22631.3007)

Can you Please correct one missing/hidden button issue in the Password app? I am using my screen readers app (JAWS, Narrator, NVDA) and none of them reads that 3 dots menu after the password(s) . When I recorded at least one password in the Password app. It was very difficult to find the menu where I can move to a different folder or how can I delete it or anything like this.

Than suddenly noticed When I navigate from the bottom of the screen to the top and reading each html element in the backward order. I noticed that my JAWS app was silent on an HTML element which is the 3 dots button for a visual person.

See the HTML elements found by JAWS screen reader app: End of main Regio 1 password 2 hours ago  – I assume this is the button. Secure Graphic AdminUser Modified 

Please make as a real button and add a label as well to read it using screen readers.

Also I ran a Accessibility Insight Fast Pass result and it found also the same: Please find this line in the report: 1 Failed button-name Ensures buttons have discernible text

I am attaching also the report. Please rename the extension of the file from .pdf to .html. I was not able to upload html file.

Thanks a lot, regards, Gabor FastPass_20240127_PasswordsNextcloud.pdf

Steps to reproduce

Just try to use any of the screen reader app and make the focus of that button. You will see that all of the screen reader apps will be silent. Also run the Microsoft Accesibility Insight app with Fast Pass and you will find the related button.

Expected behavior

As usually the screen readers read the buttons when they are labeled. This would be the goal here as well to read it and not with a button without label syntax. You may name that button as "Action" Button. I belive that the 3 dots can be still keep it as it is as the html element will be labeled and the screen readers can find those labels.

Nextcloud Logs

No response

Browser Logs

No response

marius-wieschollek commented 5 months ago

I have added a link to the menu and all menu items so they should now be recognized by the software.

You can test this on the test server here: https://next.passwordsapp.org/login with the login data "john" and the password "PasswordsApp" (in english).

The accessibility should become better at a future point when i migrate the main area to Nextclouds own ui components which have accessibility features built in already.

citygabor commented 5 months ago

Hello Marius,

Thanks for your quick support,

I was able to login to your test environment. Thanks for that this is much better to validate in this way rather than to test it on my own and proof if the button labeled or not. But now in this time it is labeled as a link.

(I created a “test” user. and noticed an other unlabeled button as well. But I raise an other issue for that.)

See my comments:

I found that “more” link easily.
is it possible to make as a real button instead of a link?
When I open that “more”” menu link I am not able to close it with an escape keyboard. However when I open the action button (new password and new folder) on the top on the screen I am able to close it easily and that is a real button.
Somehow I feel that I can still “see” that silent/hidden button before the more menu link. But when I ask my wife to check that while I am moving my (JAWS virtual ) cursor it seemed that it still staying on that 3 dots menu whenever I move to the more menu link or on the hidden button.

Is that possible to make as it is a real button and close that “more” menu with an escape button if I want to exit from that menu?

Many thanks,

Regards,

Gabor

From: M. Wieschollek @.> Sent: Sunday, January 28, 2024 2:53 PM To: marius-wieschollek/passwords @.> Cc: citygabor @.>; Author @.> Subject: Re: [marius-wieschollek/passwords] BUG]: Accessibility issue – In Password app hidden button after the password record. (Issue #633)

I have added a link to the menu and all menu items so they should now be recognized by the software.

You can test this on the test server here: https://next.passwordsapp.org/login with the login data "john" and the password "PasswordsApp" (in english).

The accessibility should become better at a future point when i migrate the main area to Nextclouds own ui components which have accessibility features built in already.

— Reply to this email directly, view it on GitHub https://github.com/marius-wieschollek/passwords/issues/633#issuecomment-1913604657 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6WGZARY7EZQL5ZSZJAL6TYQZJ5TAVCNFSM6AAAAABCNURBGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGYYDINRVG4 . You are receiving this because you authored the thread.Message ID: @.***>

marius-wieschollek / passwords