marius-wieschollek / passwords

A simple, yet feature rich password manager for Nextcloud
GNU Affero General Public License v3.0
201 stars 39 forks source link

[BUG]: single whitespace marked as "secure" #638

Closed gitbreaker222 closed 4 months ago

gitbreaker222 commented 4 months ago

⚠️ This issue respects the following points: ⚠️

Server Information

Server OS: Linux 5.15.0-88-generic x86_64
PHP Version: 8.2.12
DB Version: mysql 10.11.4

Client Information

Browser and Version: Firefox 122 Client OS and Version: Ubuntu 22.04 LTS

Bug description

passwords version: 2023.12.32 nextcloud version: Nextcloud Hub 6 (27.1.3)

Visual

writing a single whitespace in the password field grafik

...gets marked with a green Shield icon grafik

...however if I replace the single whitespace with a e.g. single number 1, the marker turns to a red shield icon.

(Note: red and green icons with same shape are not different for users, who have color blindness)

Steps to reproduce

Expected behavior

the security indicator marks single whitespaces as "unsafe"

Nextcloud Logs

No response

Browser Logs

No response

marius-wieschollek commented 4 months ago

The SHA-1 hash for a single white space is "b858cb282617fb0956d960215c8e84d1ccf909c6". This SHA has does not appear in the HIBP API for B858C. This is likely because no service allows a single white space as password. The functionality is working as intended.