[BUG]: [PHP] Error: getimagesizefromstring(): Error

snagglewest commented 7 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a single bug, not a question or a configuration/webserver/proxy issue.
[X] This is not a bug in the browser extension or another client.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server and the Passwords App is up to date. See Nextcloud Apps.
[X] There are no warnings and errors reported in the Passwords App settings in the admin area
[X] The following apps are not installed: Rainloop

Server Information

Server operating system - Ubuntu 22.04 
Web server - Apache
Database engine version - MySQL Version: 10.6.16
PHP engine version - PHP 8.2.15
Nextcloud version - 28.0.3

Client Information

Browser and Version: Chrome, Edge & Firefox Client OS and Version: Windows 10 & 11, Ubuntu 22.04, mint 21.2

Bug description

For the last several versions I have got these errors in my log. It doens't seem to effect anything but it's the only errors I get in the log. [PHP] Error: getimagesizefromstring(): Error reading from ! at /var/www/html/nextcloud/apps/passwords/lib/Helper/Image/AbstractImageHelper.php#101 GET /index.php/apps/passwords/api/1.0/service/favicon/[domain]/32 from [IPadress] by [username] at Feb 29, 2024, 7:19:15 AM

Steps to reproduce

view the nextcloud log.

Expected behavior

Errors should not appear

Nextcloud Logs

see above

Browser Logs

n/a

marius-wieschollek commented 7 months ago

I have seen this too in my logs. So far i couldn't see any issue in the files themselves. It also seems as if the same issue happens in other apps, e.g. the photos app https://github.com/nextcloud/photos/issues/2259 . Maybe it's an issue with PHP 8.2?

snagglewest commented 7 months ago

Had not seen that issue but I'm now a bit more concerned. It looks like the files in the photos app stop being displayed though they don't actually disappear or get deleted. I have not noticed any passwords not being displayed but I have over 200 passwords, many which seldom get used so it might be a possibility. I'm not a programmer by any stretch so I can't help track it down but it sounds like it needs to be a priority.

marius-wieschollek commented 6 months ago

The favicons have no impact on the passwords. They are fetched trough an extra service provided by the app and even if that fails, you can still see and use the password entries.

I have looked at this issue closer today, and i think i could fix the problem. The fix is currently available in the nightly version.

benoitdr commented 4 months ago

Seeing this too with 28.0.4

marius-wieschollek / passwords