search

marius-wieschollek / passwords

A simple, yet feature rich password manager for Nextcloud
GNU Affero General Public License v3.0
208 stars 42 forks source link

[FEATURE]: Clarify the legacy support message on the admin page #669

Open IndrekHaav opened 1 week ago

IndrekHaav commented 1 week ago

⚠️ This issue respects the following points: ⚠️

Current Status

Currently the Passwords administration page shows a generic message about the legacy support release, with a link to system requirements. It is not immediately clear, however, which requirements exactly are not being met and therefore are causing the message to be shown.

My system details are as follows:

It would seem that these meet or exceed the requirements for the Passwords app, and thus I don't understand exactly what I'm supposed to do to get rid of the message. Unless it is that I'm not running the latest Nextcloud (30)? But that was only released a few days ago and I've had the message for a while now. Plus this wiki page says that support for previous Nextcloud versions is dropped only with the first release of each year.

Feature Description

  1. I open the Passwords admin page
  2. The message clearly lists which system requirements are not being met. E.g. "You are using a legacy support release of the passwords app because (Nextcloud version XX|PHP version Y.Z|whatever else here) is not actively supported."

Additional Context

No response

marius-wieschollek commented 1 week ago

The legacy support message appears because you have the LSR version installed. Which version is installed is selected by the Nextcloud app store (unless you install it yourself). If Nextcloud will only install the LSR version but you think your server should qualify for the normal version, my tip would be to check which version of PHP you use to run cron jobs. It's likely that somewhere in your setup you don't actually use what you think you use.

IndrekHaav commented 1 week ago

Thanks for the information. I have only one version of PHP installed and that's what cron jobs use. I don't see any other versions of the Passwords app in the app store. Running occ app:install passwords says that the app is already installed.

Is the app supposed to switch automatically from the LSR to the regular version once all necessary requirements are met? If so, then that sort of circles back to my original suggestion - that the message should explicitly list any requirements that are not met so they can be addressed.

If the app is not supposed to switch back automatically, then what is the solution? Manually install the latest version (2024.9.20) from the tarball? Is that going to still get updates through Nextcloud in the future?

marius-wieschollek commented 1 week ago

The normal version is 2024.9.20 which NC will automatically install if it considers your server to fulfill the minimum requirements as listed on the appstore. I have verified this on my own Nextclouds and can confirm that it still works that way. So at the time when your Nextcloud last pulled the app list from the appstore, it decided based on its environment that your server does not fulfill the hard requirements of PHP 8.2 and NC 28 or later.

If the automatic update process of NC does not pull the latest version, the recommended solution is for you to check why that is. The most common reason is that you are in fact not running PHP 8.3 on the cli, cron or your webserver. The second most common reason is that you just updated from an older version of PHP and NC has not yet updated the applist.

Earlier versions of the app did contain their own check of which hard requirement is not fulfilled, but all that did is cause admins to complain and demand official support for their server no matter how outdated it may be. Therefore, these checks have been removed and you only see this generic message.

IndrekHaav commented 1 week ago

The second most common reason is that you just updated from an older version of PHP and NC has not yet updated the applist.

Looks like it was this one. I had in fact recently upgraded from Ubuntu 22.04 to 24.04 (and thus from PHP 8.1 to 8.3), but I thought there had been enough time for NC to check for updates. I also ran occ app:update --all and that said all my apps were up-to-date.

But then some occ commands started giving an additional message that "Nextcloud or one of the apps require upgrade". So I ran occ upgrade, which did finally update the Passwords app to 2024.9.20, and now the LSR message is gone. So all good for now, though I do wonder how long it would have taken for NC to show the available update in the web UI.

Earlier versions of the app did contain their own check of which hard requirement is not fulfilled, but all that did is cause admins to complain and demand official support for their server no matter how outdated it may be. Therefore, these checks have been removed and you only see this generic message.

Fair enough. As a NC admin, I do still think that more information would be better than less, but I understand your position. Feel free to close this issue then, and thanks again for taking the time to respond.

IndrekHaav commented 1 week ago

A quick follow-up: Do I understand correctly that 2024.9.20 is the normal version of the app and 2024.9.10 is the LSR version? And both correspond functionally to the tagged version 2024.9.0? And the same pattern applies to earlier and future versions as well?