search

marius00 / iagd

MIT License
108 stars 33 forks source link

Missed suffix #141

Closed swasher closed 5 months ago

swasher commented 2 years ago

GD ver: 1.1.9.4 IAGD ver: 1.3.8040.14253

Items don't have it's own suffix:

image image

marius00 commented 2 years ago

I'm not really sure how to reproduce that.. do you know the English name of the items? Or is this an issue with all green items?

swasher commented 2 years ago

This issue affected all green items: (red circle show 'name', must have following suffix). I will try change language to english and report result today. image

UPDATE: I tryed switch to english, reparse DB, and items suffix shown okay. Then I return to russian, and suffix dissapear again. So this problem affect only localize mode (may be only russian).

misternobousi commented 5 months ago

ItemNameCombinatorTests.cs

if (int.TryParse(entry.Replace("s", ""), out fixIndex))

change to

if (int.TryParse(entry.Replace("s", "").Replace("\r", ""), out fixIndex))

fix it.

marius00 commented 5 months ago

Fixed in 1.4.8842.11999 (https://grimdawn.evilsoft.net/GDItemAssistantBeta-1.4.8842.11999.exe)

Thanks!

misternobousi commented 5 months ago

I'm really sorry! The code I just wrote didn't fix it! The fix was probably a bug, just a coincidence! （I hit the language switch button too many times.) The Replace had to be placed right after the foreach. It gets sucked up by the if above. Anyway, \r should not be mixed in, so please create a local variable and Replace!