search

marius00 / iagd

MIT License
113 stars 34 forks source link

Improve feedback: Duplicate/Bugged items #50

Closed marius00 closed 5 years ago

marius00 commented 5 years ago

When an item is not being looted due to being a duplicate, IA should link to http://grimdawn.dreamcrash.org/ia/help.html?q=DuplicateItem

Somehow..

marius00 commented 5 years ago

Minor improvement added in the latest version.

iThinker commented 5 years ago

I've just started using GDIA and I've encountered this issues somehow, and it is not very clear (to the unsophisticated user) from the description how it happens and what to do. Is it safe to sell all "duplicated" items? I tried to search for one item, GDIA showed that item with different stats (base?), but when I retrieved the item from GDIA it indeed had identical stats. Is it possible maybe to have a setting to just automatically delete duplicated items from Stash? It might be opt-in. But it would give a seamless experience.

marius00 commented 5 years ago

Basically: 1) IA "loots" the item (IA create a copy in its own database) 2) IA deletes the item from the transfer stash (make a new stash file, without the "looted" item)

What goes wrong sometimes is in step #3, where you re-open the stash, and Grim Dawn reads the stash from memory instead of from file, causing GD to think the item still exists, and voila duplicate.

Now, I totally agree with your suggestion, it was up for a vote sometime last year, if IA should automatically delete the items, or simply warn the user (or allow item duplication). I think it would be an improvement if IA just cleaned up by deleting the item. Some users however would complain, as they've seen it, and expect to now have two of the item..

Is it safe to just delete them? Maybe. I have never seen any cases where IA was actually mistaken, but I do keep hearing reports of it, so my confidence is shaken. Every time I get involved, it turns out to have been a pure copy, but I'm very careful when it comes to just deleting items.

iThinker commented 5 years ago

My concern was that when I searched the item in IA, I saw different stats (base?) so I was like "Well, I have a different item here", but when I pulled item into stash, it was clearly a duplicate. Now my related question is. Is it expected that IA shows different items stats? Does it show item base stats? Also how does IA check if item is a duplicate? Purely by comparing all stats or seeds? If the answer is yes, then I would be pretty confident in deleting items (even manually).

marius00 commented 5 years ago

IA does not know the stats of items, which is why it only shows the base stats. IA Compares the item by looking at Prefix, Suffix, base item and the seed.

Aside from components which share the same seed, that leaves a 1/4 billion chance of ever getting the same seed (ever, not even on this specific item..) So lets call it an even 1/100bn chance IA is actually wrong. -- But if there's a bug in IA, that could of course be an issue.

iThinker commented 5 years ago

I think it is fine. Now when I understand better I am more OK. I wonder why item stats are unknown to IA? Other tools cannot know stats either?

marius00 commented 5 years ago

Being addressed, as good as it can anyways. First beta of this was released today.

To answer the last question, no tools currently know the stats. The time investment required to reverse engineer it, without help from Create, is simply not worth it.