marius311 / CMBLensing.jl

The automatically differentiable and GPU-compatible toolkit for CMB analysis.
https://cosmicmar.com/CMBLensing.jl
Other
52 stars 11 forks source link

CUDA 3 support, drop OptimKit, add diagonal Hessian updates in MAP_joint #60

Closed marius311 closed 3 years ago

marius311 commented 3 years ago

Aggregate of a bunch of things:

marius311 commented 3 years ago

@kimmywu I'm ready to merge this but can you check it doesn't break any of your marginal MAP stuff first and approve it when done?

Fyi, on NERSC, I'm now running with module load cuda/11.3.0 and export JULIA_CUDA_MEMORY_POOL=binned

I double checked with https://github.com/marius311/marginal_MAP_example/blob/master/marginal_MAP_example.ipynb and it runs fine (and MAP_marg is almost ~2x faster). I also updated the MAP_marg code to only depend on lnP, so if thats changed the MAP_marg code will be self-consistent, as well as combining the old δlnP_δϕ into MAP_marg for simplicity.

marius311 commented 3 years ago

Awesome, thank you for checking quickly. Will merge shortly.