search

marius311 / MuseInference.jl

Fast approximate high-dimensional hierarchical Bayesian inference
https://cosmicmar.com/MuseInference.jl
MIT License
32 stars 4 forks source link

compatibility with latest Turing versions #12

Closed thorek1 closed 1 year ago

thorek1 commented 1 year ago

Hi,

is there any chance of making MuseInference.jl compatible with the latest Turing version (currently 0.28)?

A lot happened since Turing 0.21.10 and it would greatly benefit my workflow to use later Turing versions.

Thanks

marius311 commented 1 year ago

Looking into it. Shouldn't be too hard in theory (famous last words).

marius311 commented 1 year ago

Can you try with https://github.com/marius311/MuseInference.jl/pull/15 and let me know if you run into any issues?

thorek1 commented 1 year ago

works fine with 1 thread and latest Turing, not with >1 threads

marius311 commented 1 year ago

Ok, latest Turing, including ForwardDiff w/ threads, is fixed on latest release (0.2.4). Zygote w/ threads doesn't work, but there's an informative error thrown now at least, that seems to be a bonafide issue on the DynamicPPL side.

itsdfish commented 5 months ago

Thank you for the package. I wanted to chime in and note that this does not work with the current release of Turing 0.33.0. Perhaps adding CompatHelper to gitactions would be a good idea.