search

mariusandra / pigeon-maps

ReactJS Maps without external dependencies
https://pigeon-maps.js.org/
MIT License
3.44k stars 142 forks source link

fix: Adds missing dev dependency #148

Closed baldulin closed 2 years ago

baldulin commented 2 years ago

When trying to run dev server using yarn start I get

yarn run v1.22.15
$ webpack-dev-server --history-api-fallback --hot --host 0.0.0.0 --port 4040
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module 'posix-character-classes'
Require stack:
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/expand-brackets/lib/compilers.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/expand-brackets/index.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/extglob/lib/compilers.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/extglob/index.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/micromatch/lib/compilers.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/micromatch/index.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/anymatch/index.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/chokidar/index.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/webpack-dev-server/lib/Server.js
- /home/user/Source/projects/pigeon/pigeon-maps/node_modules/webpack-dev-server/bin/webpack-dev-server.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/user/Source/projects/pigeon/pigeon-maps/node_modules/expand-brackets/lib/compilers.js:3:13)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/expand-brackets/lib/compilers.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/expand-brackets/index.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/extglob/lib/compilers.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/extglob/index.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/micromatch/lib/compilers.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/micromatch/index.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/anymatch/index.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/chokidar/index.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/webpack-dev-server/lib/Server.js',
    '/home/user/Source/projects/pigeon/pigeon-maps/node_modules/webpack-dev-server/bin/webpack-dev-server.js'
  ]
}

So I added expand-brackets to dev dependencies.

mariusandra commented 2 years ago

Hmm, why expand-brackets and not the posix-character-classes it is complaining about?

In any case, this was probably due to some error when merging a PR. I rebuilt yarn.lock and it seems to work now. Thanks anyway!