search

mariusbalcytis / webpack-bundle

Bundle to Integrate Webpack into Symfony
MIT License
122 stars 36 forks source link

Update AssetResolver.php #30

Closed dominikg closed 7 years ago

dominikg commented 7 years ago

in webpack2, the -loader suffix is no longer optional, without it compile fails with an error

mariusbalcytis commented 7 years ago

Thanks! I've closed this with different commit, as tests were broken.

Have you tested the bundle with webpack2? Have you had any other problems?

I'm thinking of giving possibility or just upgrading to v2. As I imagine, it would require only different package.json, webpack.config.js and sometimes js assets themselves. Am I missing something?

dominikg commented 7 years ago

Yes it requires updates to package.json and webpack.config.js. As webpack2 changed some things in regards to how options are passed to loaders (see LoaderOptionsPlugin) I'm not sure if it is possible/advisable to support both from a single base config. Might be better to just offer webpack2 in a different branch (or a 1.x branch and 2 in master).

I'll send you a working webpack2 example later.