mariusbalcytis / webpack-bundle

Bundle to Integrate Webpack into Symfony
MIT License
122 stars 36 forks source link

depecrated for SF 4.3.1 #95

Open Philalawst opened 5 years ago

Philalawst commented 5 years ago

In SF4.3.1, To resolve the deprecated error

_The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "mabawebpack" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead.

in file /src/DependencyInjection/Configuration.php

        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('maba_webpack');

become

        $treeBuilder = new TreeBuilder('maba_webpack');
        $rootNode = $treeBuilder->getRootNode();

And in the class /www/cible/venus/venus/vendor/maba/webpack-bundle/src/Twig/WebpackTokenParser.php

before

use Maba\Bundle\WebpackBundle\Service\AssetManager;
use Twig_Token as Token;
use Twig_TokenParser as TokenParser;
use Twig_Node_Expression_Function as FunctionExpression;
use Twig_Node as Node;
use Twig_Node_If as IfNode;
use Twig_Node_Set as SetNode;
use Twig_Node_Expression_AssignName as AssignNameExpression;
use Twig_Node_Expression_Constant as ConstantExpression;
use Twig_Error_Syntax as SyntaxError;
use Twig_TokenStream as TokenStream;

after

use Maba\Bundle\WebpackBundle\Service\AssetManager;
use Twig\Token;
use Twig\TokenParser\AbstractTokenParser as TokenParser;
use Twig\Node\Expression\FunctionExpression;
use Twig\Node\Node;
use Twig\Node\IfNode;
use Twig\Node\SetNode;
use Twig\Node\Expression\AssignNameExpression;
use Twig\Node\Expression\ConstantExpression;
use Twig\Error\SyntaxError;
use Twig\TokenStream;