search

mariusmotea / diyHue

Philips Hue emulator that is able to control multiple types of lights
Other
627 stars 107 forks source link

Added support for tasmota driven led controllers #443

Closed GitHobi closed 5 years ago

GitHobi commented 5 years ago

"Tasmota" is an alternative firmware for ESP8266 based devices. Tasmota also supports several led controllers. These commit adds a new protocol "tasmota" which allows to interact with such tasmota devices using diyHue (actually the HueBridge) - thus you can use standard apps to control the lights.

The changes are mainly in the "protocol/tasmota.py" area.

mariusmotea commented 5 years ago

Hi,

I see one problem, you update the function that retrieve the ip address and don't allow to manually set the ip as argument. This is important because docker based installations need to have the ip and mac address specified manually with the ones from host, not the ones from docker network. Can you update and add this functionality back?

Thanks, Marius.

GitHobi commented 5 years ago

Servus. I'm a little confused. Do you refer to "getIpAddress" function? This function is, unmodified, in functions/network.py ... I moved the function as I needed the same functionality, but did not want to copy the code. Using the HueBriedge with given MAC / IP still works, I'm passing the IP manually, too. Or do you mean anything else?

mariusmotea commented 5 years ago

You are right. I check this from my phone and i did not saw correctly . Thanks for contribution.