search

mariusmuntean / ChartJs.Blazor

Brings Chart.js charts to Blazor
https://www.iheartblazor.com/
MIT License
677 stars 151 forks source link

Samples don't compile in the current release #113

Closed sirtopas closed 4 years ago

sirtopas commented 4 years ago

Current code uses XAxes but should be xAxes https://github.com/mariusmuntean/ChartJs.Blazor/blob/4d99fa55f4cd18de7151e9d8a5bc13d07ebe7365/samples/Shared/ChartJs.Blazor.Sample.Shared/Components/LineChart/TimeLineChartComponent.razor#L74

Joelius300 commented 4 years ago

Why do you think it should be xAxes?

sirtopas commented 4 years ago

I don't, it was the only way the code compiled without error.

Joelius300 commented 4 years ago

You're probably using the nuget on version 1.1.0 right?

The code on master is the current code, the code which will be released in the future. To browse the code for the 1.1.0 release, check out the corresponding tag or the releases branch for the latest version.
There you'll find it use xAxes.

Joelius300 commented 4 years ago

Is it confusing that the samples on master aren't for the current nuget-release? On a demo-site, I'd understand that the samples need to be adjusted for the current stable version but is that the same for the repository?

I'm not sure if I'm thinking about this correctly, What do you think?

cc @mariusmuntean

Joelius300 commented 4 years ago

I just updated the readme to comply with the latest release again. Unlike the samples (can be argued about), the readme should definitely only contain stuff for the latest release and not the development version on master.