Special case for '21st' (not '21th') dataset in sample

mariusmuntean / ChartJs.Blazor

Brings Chart.js charts to Blazor

https://www.iheartblazor.com/

MIT License

691 stars 152 forks source link

Special case for '21st' (not '21th') dataset in sample #81

Closed metalmine closed 3 years ago

metalmine commented 4 years ago

Describe the bug

There's no logic for 21st data set, it becomes 21th dataset.

Which Blazor project type is your bug related to?

Client-Side
Server-Side

Which charts does this bug apply to?

Any of them that can Add Datasets

To Reproduce

Steps to reproduce the behavior: Click Add dataset until you hit 21+

Expected behavior

Show [21st Dataset]

Screenshots

https://imgur.com/a/tVLCFiN

Joelius300 commented 4 years ago

Thanks for the report.

Currently there are a lot of things that need work. I would rather focus on those instead of polishing the samples. As far as I'm concerned the samples show the usage of the library even though they aren't perfect. I hope you understand that it's more important to me to drive the library forwards instead of using my very limited time for the samples.

metalmine commented 4 years ago

Absolutely, I just wanted to document it.

Joelius300 commented 3 years ago

I'm going to close this because from now on we'll use the same form as Chart.js which is "Dataset x". I think we should be able to avoid this situation this time around :) Thanks for reporting.