search

mariusor / mpris-scrobbler

A minimalistic user daemon to submit the songs you're playing to audioscrobbler services like listenbrainz.org, libre.fm and last.fm.
MIT License
147 stars 6 forks source link

Scrobble without album #95

Open MinmoTech opened 1 year ago

MinmoTech commented 1 year ago

I usually listen to songs on youtube or songs downloaded from youtube with mpv.

For the first few tracks the scrobbling fails with the error events::add_event:queue: skipping, track is invalid. It works again if I go backwards in the queue. While I don't know why that makes it work again, the original error is caused by line 392 in scrobble.h: strlen(m->album) > 0 &&.

Because my music is downloaded from youtube often does not have an associated album.

Would it be a possibility to remove that requirement?

mariusor commented 1 year ago

Hello @MinmoTech, first of all apologies for the very late reply.

Due to the fact that Last.fm requires an album name in both the now playing and scrobble API calls, we can't remove this check. Even if we remove it, your songs would still not show up on last.fm due to the missing information.

For the other services, maybe it's possible to remove the check, but I'm no longer actively working on this, and I would need confirmation form their API docs.

A patch/pull-request (accompanied by links to the docs where listenbrainz/librefm say they accept API calls without albums) would be welcome though.

DhruvaSambrani commented 1 year ago

Listenbrainz does not require album to be sent in the payload (release_name) - https://listenbrainz.readthedocs.io/en/latest/users/json.html#payload-json-details