mariusvam / winetricks

Automatically exported from code.google.com/p/winetricks
3 stars 0 forks source link

Install check failing on MacOSX? #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
On several installs, I get error messages like below

ie7 install completed, but installed file -n 
/Users/doh123/Applications/Wineskin/TestWrapper.app/Contents/Resources/dosdevice
s/c:
/windows/ie7.log not found

just updated Winetricks as of today... this same thing happens trying to find 
files for the IE6 install that prevents it from even working.

I think its messing up because the : is not escaped and its getting confused... 
I can access the same path in terminal fine as long as I escape the colon

First found on Wineskin on Mac OS X 10.6, but happens just using standard 
command line usage as well.... "winetricks ie7"

this happened and fails on the IE6 install using standard command line Wine on 
the same system

msls31 install completed, but installed file -n 
/Users/doh123/.wine/dosdevices/c:
/windows/system32/msls31.dll not found

and the file is really there... the terminal output does have the hard return 
after the : in the output.

Original issue reported on code.google.com by doh...@gmail.com on 14 Mar 2011 at 5:48

GoogleCodeExporter commented 9 years ago
at line 1236 I can take out the verify... like below and ie6 installs fine.  
Thats not optimal, since it should check things, but the verify is failing of 
course.

# Verify install
if test "$installed_exe1" || test "$installed_file1"
then
    if ! winetricks_is_installed $1
    then
        #w_die "$1 install completed, but installed file $_W_file_unix not found"
        test line
    fi
fi

Original comment by doh...@gmail.com on 14 Mar 2011 at 6:15

GoogleCodeExporter commented 9 years ago
: shouldn't need escaping.  I just verified this:

$ touch foo:bar
$ test -f foo:bar && echo hi
hi

Does the file

/Users/doh123/Applications/Wineskin/TestWrapper.app/Contents/Resources/dosdevice
s/c:/windows/ie7.log

exist?  What does

test -f 
"/Users/doh123/Applications/Wineskin/TestWrapper.app/Contents/Resources/dosdevic
es/c:/windows/ie7.log" && echo hi

(all on one line) do?

Original comment by daniel.r...@gmail.com on 17 Mar 2011 at 8:36

GoogleCodeExporter commented 9 years ago
yes.. the files exit.. It happens on many many verbs on the current version of 
Winetricks and it didn't use to happen during older Winetricks-alpha

Its not just this one thing, but the verify install function I listed above 
never finds files in ANYTHING I can run in Winetricks, it always has the same 
error, and all of the files it searches for always exist.  Even happened on 
mdac28 today.

It can usually be ignored because its no big deal, but in some like IE6 
install, it prevents anything from even installing.

In IE6 it comes back as this

msls31 install completed, but installed file -n 
/Users/doh123/Applications/Wineskin/quartz-wm-Test.app/Contents/Resources/dosdev
ices/c:
/windows/system32/msls31.dll not found

and IE6 set up never starts... now the file is there.. I'm not mistaking it.. 
it is really there, the test in Winetricks is failing to work right.  If I make 
the change like I listed above to get rid of the w_die line, then IE6 will go 
ahead and install and work just fine.

It may be nothing at all to do with escaping, but the test for checking if a 
file exists is failing... at least on Mac OS X.

Original comment by doh...@gmail.com on 17 Mar 2011 at 11:13

GoogleCodeExporter commented 9 years ago
Sure, the files exist, but what does

test -f 
"/Users/doh123/Applications/Wineskin/TestWrapper.app/Contents/Resources/dosdevic
es/c:/windows/ie7.log" && echo hi

output?  I'm trying to narrow down where the problem is.

Original comment by daniel.r...@gmail.com on 20 Mar 2011 at 11:14

GoogleCodeExporter commented 9 years ago

Original comment by daniel.r...@gmail.com on 20 Mar 2011 at 11:15

GoogleCodeExporter commented 9 years ago
modified a bit.. but test should be valid

Optimus:~ doh123$ test -f 
"/Users/doh123/.wine/dosdevices/c:/windows/notepad.exe" && echo hi
hi
Optimus:~ doh123$

so I'm guessing its nothing to do with escaping like my first thought.

Original comment by doh...@gmail.com on 21 Mar 2011 at 1:48

GoogleCodeExporter commented 9 years ago
I just noticed a clue:
  "ie7 install completed, but installed file -n ..."

Hey, what's that stray -n doing there?  
Can you track that down, or send me a verbose log?
Looks like the path conversion function is screwing up and sticking garbage in 
its result.

Original comment by daniel.r...@gmail.com on 21 Mar 2011 at 2:57

GoogleCodeExporter commented 9 years ago
winetricks_wintounix()
{
    _W_winp_="$1"
    # Remove drive letter and colon
    _W_winp="${_W_winp_#??}"
    # Prepend the location of drive c
    echo -n ${WINEPREFIX}/dosdevices/c:
    # Change backslashes to slashes
    echo $_W_winp | sed 's,\\,/,g' 
}
around line 299 .... this is where the -n gets put in.... if I take it out it 
has the same error without the -n... so might just be reporting back wrong and 
not really checking a -n there.

Original comment by doh...@gmail.com on 21 Mar 2011 at 6:11

GoogleCodeExporter commented 9 years ago
I was warned about echo -n, it's my fault.  Fix coming tonight or so.

Original comment by daniel.r...@gmail.com on 21 Mar 2011 at 6:45

GoogleCodeExporter commented 9 years ago
OK, try winetricks from svn, it uses printf %s instead of echo -n.

Original comment by daniel.r...@gmail.com on 23 Mar 2011 at 12:14

GoogleCodeExporter commented 9 years ago
I tried the SVN version and it works fine on all the things it was failing on 
before!!  looks fixed to me!

Original comment by doh...@gmail.com on 23 Mar 2011 at 1:34