Support for tiles - Githubissues

mariusz-ostoja-swierczynski / tech-controllers

TECH Controllers integration for Home Assistant

MIT License

96 stars 67 forks source link

Support for tiles #15

Closed mariusz-ostoja-swierczynski closed 8 months ago

mariusz-ostoja-swierczynski commented 2 years ago

This is now done and merged to dev and will be hopefully soon merged to master.

@maciej-or I had to comment out bit of code in sensor.py:

# TODO: this sensor's ID assignment needs to be fixed as base on such ID
# tech api doesn't return value and we get KeyError
#
# class TileValveTemperatureSensor(TileSensor):

If you have time, please look on this if you can fix it.

maciej-or commented 2 years ago

hi @mariusz-ostoja-swierczynski, I've checked current dev branch. I'm not sure if it's mistake by merging or intended change but all sensors have device instances. Logically should be 1 device with multiple sensors. In my case it is 1 boiler (device) and 18 sensors (entities).

my initial PR:

and current dev with my boiler:

jontofront commented 2 years ago

In my case dev branch works ok, I have 8 zones = device. One device is Boiler pump

maciej-or commented 2 years ago

Well, I suppose it's wrong mapping to Home Assistant structures. You have 1 device (L4 controller) with 8 HVACs (zones) and 1 binary sensor or switch (pump). see: https://www.home-assistant.io/integrations/climate Zones should have index 1-8 and belong to the same device. Imagine you have more than one L4 controller or more than one boiler. I would expect their entities will be grouped by device.