search

mariuszfoltak / angular2-datatable

DataTable - Simple table component with sorting and pagination for Angular2
202 stars 182 forks source link

add support to angular 6 and new rxjs #163

Open behroozbc opened 6 years ago

behroozbc commented 6 years ago

hi I use angular 6 I cant run your package I have rxjs error please update your package

jorgeemherrera commented 6 years ago

Yes, please, me either run it.

PascalHonegger commented 6 years ago

Duplicate of #156 => I created a fork (of a fork...) which has the minimal changes required for angular 6 to run (https://github.com/PascalHonegger/ng-datatable - https://www.npmjs.com/package/@pascalhonegger/ng-datatable). We use this version for our project and were able to get rid of the rxjs-compat package. I'm also happy to keep it updated / merged wherever an active version of this package lives.

pumano commented 4 years ago

@PascalHonegger love your fork, but you don't have issues in your fork, so I write here :) Would love if you add support for angular 9, because since angular 9 your fork @pascalhonegger/ng-datatable not working for production build:

ERROR in node_modules/@pascalhonegger/ng-datatable/lib/src/DataTableModule.d.ts:1:22 - 
error NG6002: Appears in the NgModule.imports of TasksModule, but could not be resolved to an NgModule class

1 export declare class DataTableModule {
PascalHonegger commented 4 years ago

@pumano Appreciate your comment! I got an Angular 9 version running locally yesterday, will try to publish it today if testing goes smoothly. Had to re-do the whole build / test pipeline using Angluar-CLI, which was a pain. (And issues have been enabled on the repo 😉)

PascalHonegger commented 4 years ago

@pumano Published with version 9.0.1 of @pascalhonegger/ng-datatable, feel free to open an issue in case it isn't working. I tried my best, but with such a massive change in build pipeline it would be a miracle if everything worked first try.

pumano commented 4 years ago

@PascalHonegger thanks! I will try today