search

mariuszfoltak / angular2-datatable

DataTable - Simple table component with sorting and pagination for Angular2
202 stars 182 forks source link

Support for Angular 4 #98

Open memark opened 7 years ago

memark commented 7 years ago

When trying to use version 0.6.0 with Angular 4 I get warnings of unmet dependencies. Are there any plans to support Angular 4? Or is it perhaps already supported, but the dependencies need to be upgraded? (Maybe something like ^2.0.0 | ^4.0.0?)

bsartain commented 7 years ago

After upgrading to Angular 4 I get the following error........................

ERROR in Error encountered resolving symbol values statically. Calling function 'makeDecorator', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol NgModule in C:/webroot/ceto-cli -ng4/node_modules/angular2-datatable/node_modules/@angular/core/src/metadata/ng_module.d.ts, resolving symbol NgModule in C:/webroot/ceto-cli -ng4/node_modules/angular2-datatable/node_modules/@angular/core/src/metadata.d.ts, resolving symbol NgModule in C:/webroot/ceto-cli -ng4/node_modules/angular2-datatable/node_modules/@angular/core/src/core.d.ts, resolving symbol NgModule in C:/webroot/ceto-cli -ng4/node_modules/angular2-datatable/node_modules/@angular/core/index.d.ts, resolving symbol DataTableModule in C:/webroot/ceto-cli -ng4/node_modules/angular2-datatable/lib/DataTableModule.d.ts, resolving symbol DataTableModule in C:/webroot/ceto-cli -ng4/node_modules/angular2-datatable/lib/DataTableModule.d.ts

Any solution would be most helpful.

UPDATE: I ran the npm i -S angular2-datatable and upgraded to 6.0.0 and it worked fine.

danielptm commented 7 years ago

Had the same problem here, and upgrading to 6.0.0 solved it.

dinusuresh commented 7 years ago

@bsartain @danielptm 6.0.0 ?

I am using 0.6.0 with Angular-4.0.3 and I am facing the same error as specified by @bsartain

ZenabKhan commented 7 years ago

@dinusuresh Had the same issue. I was also using 0.6.0 with Angular-4.0.3. I removed my node_modules folder and ran npm install everything worked fine.

memark commented 7 years ago

It seems you have borrowed this thread. It's supposed to be about the package dependency problem. :)

But still, is there no developer reading/answering?

memark commented 7 years ago

I have sent a very basic PR for this issue, just upgrading the peerDependencies. Would you be able to take a look at it @mariuszfoltak?

memark commented 7 years ago

Starting to wonder if this project is all dead by now. :/

bsartain commented 7 years ago

@memark sorry I haven't had a chance to reply. Life get's in the way. If it's any encouragement, this project has done great things for our application. I can't thank you enough for it.

kunleawotunbo commented 7 years ago

I upgraded to 0.6.0 and issue fixed. "angular2-datatable": "^0.6.0"

Lycidas0815 commented 7 years ago

Promising project, but if you can not use it in a current Angular 4.x environment, there is not much use :/