Closed philipbelesky closed 4 years ago
A very good idea, Philip! I like how you structured the whole thing. I'm not very experienced in this matter either, so I guess we'd have to experiment a bit to get it right.
For the sake of having an overview, a list of analysis that could be meaningful follows.
Not saying we should implement all of these, but it's worth having a bigger picture when laying foundations for future work.
Good progress on this one today! Do you think this is ready to be merged to master now?
I’ll need to check it on a live setup as the above was done without access to a Kinect, but assuming that works I’ll mark it for a code review when its ready. I might have a look at the Color ramps branch and see if it can be integrated with that.
Ok, I think this should be ready for review. A couple of notes:
GetPixelColorForAnalysis
; not sure if that should be handled with operator overloading / generics / or some other implementation that will allow each class to accept varying inputs.
SolveInstance
that will call into enabled options and allow them to output geometry (e.g. contours).
This is very much a work in progress / for feedback PR. This sketches out a series of classes in
Analysis.cs
that are each tied to a particular analysis/visualization method, such as the existing elevation/blank options, future options such as #13, and color/gradient variations.Each class should ideally:
I'm not super experienced with proper composition/inheritance patterns in C# so thought I would put this out there to see if its roughly appropriate. Feel free to revise/finish/trash as necessary.