search

mariuszhermansdorfer / SandWorm

Augmented Reality Sandbox for Grasshopper & Rhino
MIT License
20 stars 11 forks source link

Draw waterLevel as a plane rather than part of the mesh color #33

Closed mariuszhermansdorfer closed 4 years ago

mariuszhermansdorfer commented 4 years ago

Current implementation of waterLevel being part of mesh coloring logic is causing some headache. Why don’t we implement it as a separate object (a plane?) whose visibility would be toggled by our existing right click menu option instead?

I was never really happy with the visual quality of our current approach. Having a separate water plane would allow us to assign a custom material to it with proper opacity, absorption and maybe even bump. Dunno how fast these things would render but it’s still worth giving a shot.

philipbelesky commented 4 years ago

That would definitely simplify the implementation, I can make the change as part of the other reworkings of the analysis classes.

philipbelesky commented 4 years ago

Closing as this was completed as part of #34. I never noticed it take more than 0ms so there shouldn’t be any concerns with performance. Feel free to reopen if there are any questions or improvements for the implementation.