mariuszhermansdorfer / SandWorm

Augmented Reality Sandbox for Grasshopper & Rhino
MIT License
20 stars 11 forks source link

Generalize kinect variables for Azure Support #67

Closed BarusXXX closed 3 years ago

BarusXXX commented 3 years ago

There 2 places where I could not generalize the access to kinect Type variable currently selected by the user;

Here; https://github.com/mariuszhermansdorfer/SandWorm/blob/2b53d409f3cc18aa32da5d14bd61c5a1802dead8/SandWorm/Components/BaseKinectComponent.cs#L27

And setting the depth mode Here; https://github.com/mariuszhermansdorfer/SandWorm/blob/2b53d409f3cc18aa32da5d14bd61c5a1802dead8/SandWorm/Sensors/K4AController.cs#L74

Using the depth mode fetching implimented here; https://github.com/mariuszhermansdorfer/SandWorm/blob/2b53d409f3cc18aa32da5d14bd61c5a1802dead8/SandWorm/Sensors/K4AController.cs#L56

These need to reference the active kinect type by the user. Idea for future: We should be able to detect the kinect type currently connected, and only give the user access to different depth modes.

BarusXXX commented 3 years ago

https://github.com/mariuszhermansdorfer/SandWorm/blob/67e8efc9fcedc830d4ff22938853332ec0dd2826/SandWorm/Components/BaseKinectComponent.cs#L114

On placing the Options Component on Canvas this line active width and active height are unassigned unless default kinect is the one currently connected, we should either detect it or set it as Null as @philipbelesky suggested pausing for user input.

BarusXXX commented 3 years ago

@philipbelesky The device config needs to be reset when ever the user changes the depth mode, currently I noticed that the camera mode is not changed when the user goes from Narrow to Wide.... . From Narrow to Wide you get the out of bounds error.

ie,