mariuz / flamerobin

FlameRobin is a database administration tool for Firebird RDBMS. Our goal is to build a tool that is: lightweight (small footprint, fast execution) cross-platform (Linux, Windows, Mac OS X, FreeBSD) dependent only on other Open Source software
http://flamerobin.org
MIT License
216 stars 66 forks source link

wxWidget 3.1.4 compatibility #119

Closed arvanus closed 3 years ago

arvanus commented 4 years ago

Almost everything looks to work fine, but Privileges tab is buggy, the hint work like a Win98 computer 😄 image

in the HTML, looks like <a href="info://Granted by SYSDBA"> works fine until wxHtmlWindow 3.1.3. At 3.1.4 wx team switched to an Edge implementation in Windows: https://www.wxwidgets.org/news/2020/07/wxwidgets-3.1.4-released/

 <tbody>
    <tr bgcolor="navy">
      <td><b><font color="white">Grantee</font></b></td>
      <td><b><font color="white">Select</font></b></td>
      <td><b><font color="white">Insert</font></b></td>
      <td><b><font color="white">Update</font></b></td>
      <td><b><font color="white">Delete</font></b></td>
      <td><b><font color="white">Reference</font></b></td>
    </tr>

    <tr bgcolor="#DDDDFF">
      <td nowrap valign="top">SYSDBA</td>
      <td valign="top" align="center"><a href="info://Granted by SYSDBA">
          <img src="html-templates\ok2.png"></a><font size="-1"></font>

      </td>
      <td valign="top" align="center"><a href="info://Granted by SYSDBA">
          <img src="html-templates\ok2.png"></a><font size="-1"></font>

      </td>
      <td valign="top" align="center"><a href="info://Granted by SYSDBA">
          <img src="html-templates\ok2.png"></a><font size="-1"></font>

      </td>
      <td valign="top" align="center"><a href="info://Granted by SYSDBA">
          <img src="html-templates\ok2.png"></a><font size="-1"></font>

      </td>
      <td valign="top" align="center"><a href="info://Granted by SYSDBA">
          <img src="html-templates\ok2.png"></a><font size="-1"></font>

      </td>
    </tr>
  </tbody>
</table>
luronumen commented 4 years ago

Interesting bug. Let's see how we can fix this.

arvanus commented 4 years ago

Looks like something here: https://github.com/mariuz/flamerobin/blob/7e926d5a5271e1650a30209defc31163e2e30888/src/gui/MetadataItemPropertiesFrame.cpp#L337-L351 At previous version, you wasn't required to release the previous wxTipWindow or something like this I Will work on this :)

luronumen commented 4 years ago

Excellent @arvanus !

luronumen commented 3 years ago

Hi @arvanus,

Is this issue still reproducible in 0.9.3.8 Snapshot version?

arvanus commented 3 years ago

No, thanks