Unable to drop functions

mariuz / flamerobin

FlameRobin is a database administration tool for Firebird RDBMS. Our goal is to build a tool that is: lightweight (small footprint, fast execution) cross-platform (Linux, Windows, Mac OS X, FreeBSD) dependent only on other Open Source software

http://flamerobin.org

MIT License

214 stars 66 forks source link

Unable to drop functions #182

Closed luronumen closed 2 years ago

luronumen commented 3 years ago

ISSUE 1:

Unable to drop functions

DropFunctions

ISSUE 2:

The output parameter is listed before the input parameters.

InputParameters

STEPS TO REPRODUCE THE ISSUES:

ISSUE 1: Right Click a functions and select Drop option from context popup menu: Verify that << Drop SQL >> instructions is displayed instead of the SQL instructions for delete the function
ISSUE 2: Check how the input and output parameters are listed in a function: verify the output parameter is listed before the input parameters. Note that in procedures this issue is not reproducible.

Jdochoa commented 3 years ago

Issue 1: Fixed.
Issue 2: I'm not sure of this, in the rdb$function_arguments firebird define the result in position 0, and ISQL list the arguments in this order

luronumen commented 3 years ago

Issue 1: Thanks for the fix. I will retest it in the next version ;)
Issue 2: How the procedures detects if a parameter is in or out. May be is the same logic.

Thank you very much for all improvement that you are doing on FlameRobin!

Best Regards, Luciano

luronumen commented 3 years ago

Issue 1: Thanks for the fix. I will retest it in the next version ;)

Issue 2: How the procedures detects if a parameter is in or out. May be is the same logic.

Thank you very much for all improvement that you are doing on FlameRobin!

Best Regards, Luciano

Hi @Jdochoa

Retest result on flamerobin.zip:

Issue 1: Partial fixed! The functions is dropped but it is still listed on Functions node. User have to refresh the Functions node manually to the deleted functions be removed from the functions node
Issue 2: It is still reproducible.

Jdochoa commented 3 years ago

Hi @luronumen Can you give me feedback on this or close it? Please view the last commit on my repository.

Thanks ./jo

luronumen commented 3 years ago

Hi @luronumen Can you give me feedback on this or close it? Please view the last commit on my repository.

Thanks ./jo

Hi @Jdochoa

Could you please generate a FlameRobin build for me for retest it?

Thanks in adevance, Luciano

arvanus commented 2 years ago

@luronumen can you try this again please? Thanks

luronumen commented 2 years ago

Hi @arvanus and @Jdochoa

Retest result on flamerobin-0.9.3.b236510a-setup-x64.exe:

Issue 1: Partial fixed! The functions is dropped but it is still listed on Functions node. User have to refresh the Functions node manually to the deleted functions be removed from the functions node
Issue 2: It is still reproducible.

luronumen commented 2 years ago

Retest result on FlameRobin 0.9.3.12: PASS! Thank you very much for the fix!

Best Regards, Luciano