search

mariuz / flamerobin

FlameRobin is a database administration tool for Firebird RDBMS. Our goal is to build a tool that is: lightweight (small footprint, fast execution) cross-platform (Linux, Windows, Mac OS X, FreeBSD) dependent only on other Open Source software
http://flamerobin.org
MIT License
214 stars 66 forks source link

Some minor issues on the functions and procedures summary tab #183

Open luronumen opened 3 years ago

luronumen commented 3 years ago

Some minor issues on the functions and procedures summary tab:

FunctionsProcedures

luronumen commented 3 years ago

This issue is also reproducible on Domains, Database Triggers, DDL Triggers, Triggers and Views.

steveh454 commented 3 years ago

with version 0.9.3.7 I cannot open any procedures for editing. Had to go back to version 0.9.2.1851 Get an error -206, Column does not belong to referenced table. Column seems to be RDB$FIELD_NAME

luronumen commented 3 years ago

with version 0.9.3.7 I cannot open any procedures for editing. Had to go back to version 0.9.2.1851 Get an error -206, Column does not belong to referenced table. Column seems to be RDB$FIELD_NAME

Hi @steveh454,

I retested using the 0.9.3.7 Snapshot and I was not able to reproduce the issue mentioned by you.

Could you please confirm the steps to reproduce the issue? Right mouse click on a stored procedure and then select Alter.

Jdochoa commented 3 years ago

with version 0.9.3.7 I cannot open any procedures for editing. Had to go back to version 0.9.2.1851 Get an error -206, Column does not belong to referenced table. Column seems to be RDB$FIELD_NAME

Hi @steveh454 The error is you version of firebird. Please confirm if you used FB 2.1 or minor. I made the mistake of not validating the firebird version

steveh454 commented 3 years ago

Sorry for delay, I have more info on the versions of Firebird and FlameRobin. Using 32 bit Firebird v2.5 The screenshots show the 2 versions of FlameRobin 0.9.3 and 0.9.2. I have taken screenshots of the Firebird engine version, how the 2 versions look when connected to a database, and what happens when trying to Alter the same procedure with 0.9.2 and 0.9.3 Notice the icons are different for procedures in 0.9.3, also if I try to edit any procedure in 0.9.3 I get a big error. But editing the same procedure with 0.9.2 works fine. The images are in a jumbled order, but you should be able to figure out what is going on. The 0.9.2 version has red cog icons for the procedures and 0.9.3 has small brick icons. alter-092 err-093 robin-0 9 2 robin-0 9 3 robin-0 9 3-version

luronumen commented 1 year ago

This issue is still reproducible on FlameRobin version 0.9.6.

arvanus commented 11 months ago

So, looks like the space is simply some margin of 10px that (I think) wxWidget 3.2 introduced TODO: add style="margin-top: 0px;margin-bottom: 0px;" to <pre> tags in every template with related problem