Grid decimal seperator

[Zeki-Gursoy]

Grid decimal seperator is "." dot. Can it take from system setting for other cultures ?

[nLeonardt95]

I would like that very much, too.

[arvanus]

@Jdochoa this is a nice feature, but breaks compatibility with "COPY AS INSERT/UPDATE" I'll suggest to rollback for now because this breaks current behavior with the iteration with Firebird itself when I change a value directly from the grid (update)

[arvanus]

@Jdochoa I'll comment this line: https://github.com/mariuz/flamerobin/blob/f909af0786116f5d871c1c6138b4226b71affbc6/src/main.cpp#L84 and generate a new snapshot, ok?

[Jdochoa]

@Jdochoa I'll comment this line:

https://github.com/mariuz/flamerobin/blob/f909af0786116f5d871c1c6138b4226b71affbc6/src/main.cpp#L84

and generate a new snapshot, ok?

OK

Could you wait until the weekend? ./jo

[arvanus]

@Jdochoa I downloaded and tried this option, but looks like location is always enabled checking or not the checkbox at Preferences my grid has ',' (comma) instead of '.' (dot) By the way my locale is indeed ',' (comma) but I prefer using dot 😸

[Jdochoa]

@Jdochoa I downloaded and tried this option, but looks like location is always enabled checking or not the checkbox at Preferences my grid has ',' (comma) instead of '.' (dot) By the way my locale is indeed ',' (comma) but I prefer using dot 😸

Hi @arvanus I can't reproduce it. you have more information?

The next snapshot depend of this.

Thank you.

./jo

[arvanus]

Hello @Jdochoa! So, I unchecked this option and the grid keep using comma, just after I closed and reopened completely Fr that if worked OK I think that just putting a label informing the need to restart is enough! Something like this:

[arvanus]

I found the "problem" https://github.com/mariuz/flamerobin/blob/4f17dc5b88e09fc7bc460ae1647af153b37e2eb8/src/config/Config.cpp#L409 default should be "false" I'll change it right here and commit For now, it's good enough to the snapshot!

[arvanus]

Or... change here to true: https://github.com/mariuz/flamerobin/blob/4f17dc5b88e09fc7bc460ae1647af153b37e2eb8/conf-defs/fr_settings.confdef#L15 You decide @Jdochoa :)

[Jdochoa]

@arvanus i committed two changes:

• Change default to "False"
• Reload configuration to save changes to settings.

With this, please generate a new snapshot. ./jo

[arvanus]

Nice! please pull request :)

[arvanus]

Perfect! :D I'll edit What's New in the docs and generate a snapshot

[arvanus]

New snapshot available! https://github.com/mariuz/flamerobin/releases/tag/0.9.3.8

@Zeki-Gursoy can you try this snapshot and close this issue? @Jdochoa you are awesome :) Thanks!

[Zeki-Gursoy]

Perfect for pasting into Excel and exporting to CSV. @Jdochoa, Thank you very much ;)

[arvanus]

@Jdochoa when I try to update a integer value, I'm getting this error here: Here: https://github.com/mariuz/flamerobin/blob/d4a6eae13a7b04803cb08c3acb1789c55cd0de8f/src/gui/controls/DataGridRows.cpp#L558-L559

Debugging, the string comes as "1.0000" instead of simply '1' This error occurs since snapshot 8