search

mariuz / flamerobin

FlameRobin is a database administration tool for Firebird RDBMS. Our goal is to build a tool that is: lightweight (small footprint, fast execution) cross-platform (Linux, Windows, Mac OS X, FreeBSD) dependent only on other Open Source software
http://flamerobin.org
MIT License
214 stars 66 forks source link

Field Editor in Grid assumes numeric input always as decimal values #210

Closed pgiacomo69 closed 2 years ago

pgiacomo69 commented 3 years ago

When editing a value in grid, if you write only numeric digits then the value is considered to be float regardless of column type, so, if you put '1' in a varchar field, the field is updated with "1.000000" value. So it is impossible to edit a varchar field if you intend to write only numeric chars. Edit integer fields it is impossible at all, since it raises an error "Invalid Integer Numeric Value". The error is present from 0.9.3.8 version, and still present with 0.9.3.9. In the screenshot, I'm trying to write "1048" in "COD" colum, defined as Varchar(4).

Immagine 2021-06-09 140526

pgiacomo69 commented 3 years ago

Has anyone other encountered this issue? Can be caused by the code at https://github.com/mariuz/flamerobin/blob/3e169310f86434a40d20b39f998734a994b5d993/src/gui/controls/DataGridRows.cpp#L2100 ?

Jdochoa commented 3 years ago

Has anyone other encountered this issue? Can be caused by the code at

https://github.com/mariuz/flamerobin/blob/3e169310f86434a40d20b39f998734a994b5d993/src/gui/controls/DataGridRows.cpp#L2100 ?

Hi @pgiacomo69 .

Please, review the solution at https://github.com/Jdochoa/flamerobin.git

./jo

pgiacomo69 commented 3 years ago

I'll have to wait for a new snapshot, since I haven't set the build environment. There is a guide to setup it on windows with VS? The doc is outdated.

Jdochoa commented 3 years ago

I'll have to wait for a new snapshot, since I haven't set the build environment. There is a guide to setup it on windows with VS? The doc is outdated.

Use this. flamerobin.zip

./jo

fperana commented 2 years ago

This seems to be solved in the latest snapshot 0.9.3.10. Maybe it should be closed.