mariuz / flamerobin

FlameRobin is a database administration tool for Firebird RDBMS. Our goal is to build a tool that is: lightweight (small footprint, fast execution) cross-platform (Linux, Windows, Mac OS X, FreeBSD) dependent only on other Open Source software
http://flamerobin.org
MIT License
211 stars 64 forks source link

Fix Mac OS compilation #328

Closed rlakis closed 9 months ago

rlakis commented 9 months ago

on my MacbookPro (Mac OS 13 and 14) it did not match It looks outdated may be for Carbon Mac

On Tue, Oct 3, 2023 at 4:13 PM arvanus @.***> wrote:

@.**** commented on this pull request.

In src/config/Config.h https://github.com/mariuz/flamerobin/pull/328#discussion_r1344084879:

@@ -44,7 +44,7 @@ class wxFileConfig;

//! Do not instantiate objects of this class. Use config() function (see below).

-#if defined(UNIX) && !defined(__WXMAC_OSX__)

isn't WXMAC_OSX directive used anymore? Thank you

— Reply to this email directly, view it on GitHub https://github.com/mariuz/flamerobin/pull/328#pullrequestreview-1655183648, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADITO7S4D5AG445VF7572VLX5QFNXAVCNFSM6AAAAAA5Q65PROVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJVGE4DGNRUHA . You are receiving this because you authored the thread.Message ID: @.***>

arvanus commented 9 months ago

So could you adjust to keep this older directive too?

arvanus commented 9 months ago

Don't know if we have users using this OS

rlakis commented 9 months ago

With the release of macOS 10.15 Catalina, the Carbon API was officially discontinued and removed, leaving Cocoa as the sole primary API for developing macOS applications. Apple Inc.

Current Mac OS version is 14.0

On Tue, Oct 3, 2023 at 4:46 PM arvanus @.***> wrote:

Don't know if we have users using this OS

— Reply to this email directly, view it on GitHub https://github.com/mariuz/flamerobin/pull/328#issuecomment-1745013237, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADITO7SVNGJMOMSIBSRHCSDX5QJJ3AVCNFSM6AAAAAA5Q65PROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVGAYTGMRTG4 . You are receiving this because you authored the thread.Message ID: @.***>